Title: [233961] branches/safari-606-branch/Tools
- Revision
- 233961
- Author
- [email protected]
- Date
- 2018-07-18 19:00:27 -0700 (Wed, 18 Jul 2018)
Log Message
Cherry-pick r233889. rdar://problem/42343023
[macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
https://bugs.webkit.org/show_bug.cgi?id=187730
Patch by Aditya Keerthi <[email protected]> on 2018-07-17
Reviewed by Jer Noble.
This regression was introduced by r233865. PIP can now only be initiated from a
window that is on screen.
* TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
(TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-606-branch/Tools/ChangeLog (233960 => 233961)
--- branches/safari-606-branch/Tools/ChangeLog 2018-07-19 02:00:24 UTC (rev 233960)
+++ branches/safari-606-branch/Tools/ChangeLog 2018-07-19 02:00:27 UTC (rev 233961)
@@ -1,5 +1,36 @@
2018-07-18 Babak Shafiei <[email protected]>
+ Cherry-pick r233889. rdar://problem/42343023
+
+ [macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=187730
+
+ Patch by Aditya Keerthi <[email protected]> on 2018-07-17
+ Reviewed by Jer Noble.
+
+ This regression was introduced by r233865. PIP can now only be initiated from a
+ window that is on screen.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
+ (TestWebKitAPI::TEST):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233889 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2018-07-17 Aditya Keerthi <[email protected]>
+
+ [macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=187730
+
+ Reviewed by Jer Noble.
+
+ This regression was introduced by r233865. PIP can now only be initiated from a
+ window that is on screen.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
+ (TestWebKitAPI::TEST):
+
+2018-07-18 Babak Shafiei <[email protected]>
+
Cherry-pick r233888. rdar://problem/42345191
Add completion handlers to TestRunner functions setStatisticsLastSeen(), setStatisticsPrevalentResource(), setStatisticsVeryPrevalentResource(), setStatisticsHasHadUserInteraction(), and setStatisticsHasHadNonRecentUserInteraction()
Modified: branches/safari-606-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm (233960 => 233961)
--- branches/safari-606-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm 2018-07-19 02:00:24 UTC (rev 233960)
+++ branches/safari-606-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm 2018-07-19 02:00:27 UTC (rev 233961)
@@ -122,6 +122,7 @@
RetainPtr<NSWindow> window = adoptNS([[NSWindow alloc] initWithContentRect:[webView frame] styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:NO]);
[[window contentView] addSubview:webView.get()];
+ [window makeKeyAndOrderFront:nil];
NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"PictureInPictureDelegate" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
