Title: [233956] branches/safari-606-branch/Tools
- Revision
- 233956
- Author
- [email protected]
- Date
- 2018-07-18 19:00:04 -0700 (Wed, 18 Jul 2018)
Log Message
Cherry-pick r233878. rdar://problem/42343023
Fix API Test failures introduced by r233865
https://bugs.webkit.org/show_bug.cgi?id=187720
Unreviewed APITest fix after r233865.
Fullscreen can now only be initiated from a window that is on screen.
Patch by Jeremy Jones <[email protected]> on 2018-07-16
* TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
(TestWebKitAPI::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-606-branch/Tools/ChangeLog (233955 => 233956)
--- branches/safari-606-branch/Tools/ChangeLog 2018-07-19 02:00:01 UTC (rev 233955)
+++ branches/safari-606-branch/Tools/ChangeLog 2018-07-19 02:00:04 UTC (rev 233956)
@@ -1,5 +1,39 @@
2018-07-18 Babak Shafiei <[email protected]>
+ Cherry-pick r233878. rdar://problem/42343023
+
+ Fix API Test failures introduced by r233865
+ https://bugs.webkit.org/show_bug.cgi?id=187720
+
+ Unreviewed APITest fix after r233865.
+
+ Fullscreen can now only be initiated from a window that is on screen.
+
+ Patch by Jeremy Jones <[email protected]> on 2018-07-16
+
+ * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
+ (TestWebKitAPI::TEST):
+ * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
+ (TestWebKitAPI::TEST):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2018-07-16 Jeremy Jones <[email protected]>
+
+ Fix API Test failures introduced by r233865
+ https://bugs.webkit.org/show_bug.cgi?id=187720
+
+ Unreviewed APITest fix after r233865.
+
+ Fullscreen can now only be initiated from a window that is on screen.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
+ (TestWebKitAPI::TEST):
+ * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
+ (TestWebKitAPI::TEST):
+
+2018-07-18 Babak Shafiei <[email protected]>
+
Cherry-pick r233869. rdar://problem/42344023
Allow removal of white backgrounds
Modified: branches/safari-606-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm (233955 => 233956)
--- branches/safari-606-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm 2018-07-19 02:00:01 UTC (rev 233955)
+++ branches/safari-606-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm 2018-07-19 02:00:04 UTC (rev 233956)
@@ -94,6 +94,7 @@
RetainPtr<NSWindow> window = adoptNS([[NSWindow alloc] initWithContentRect:[webView frame] styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:NO]);
[[window contentView] addSubview:webView.get()];
+ [window makeKeyAndOrderFront:nil];
NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"FullscreenDelegate" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
[webView loadRequest:request];
Modified: branches/safari-606-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm (233955 => 233956)
--- branches/safari-606-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm 2018-07-19 02:00:01 UTC (rev 233955)
+++ branches/safari-606-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm 2018-07-19 02:00:04 UTC (rev 233956)
@@ -65,6 +65,7 @@
RetainPtr<NSWindow> window = adoptNS([[NSWindow alloc] initWithContentRect:[webView frame] styleMask:NSWindowStyleMaskBorderless backing:NSBackingStoreBuffered defer:NO]);
[[window contentView] addSubview:webView.get()];
+ [window makeKeyAndOrderFront:nil];
NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"FullscreenTopContentInset" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
[webView loadRequest:request];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
