Title: [233969] branches/safari-606-branch/Source/WebKit
- Revision
- 233969
- Author
- [email protected]
- Date
- 2018-07-18 19:00:54 -0700 (Wed, 18 Jul 2018)
Log Message
Cherry-pick r233925. rdar://problem/42354959
Dissociate the VideoFullscreenInterface from its VideoFullscreenModel before removing it from the manager
https://bugs.webkit.org/show_bug.cgi?id=187775
<rdar://problem/42343229>
Reviewed by Jon Lee.
* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::didCleanupFullscreen):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-606-branch/Source/WebKit/ChangeLog (233968 => 233969)
--- branches/safari-606-branch/Source/WebKit/ChangeLog 2018-07-19 02:00:51 UTC (rev 233968)
+++ branches/safari-606-branch/Source/WebKit/ChangeLog 2018-07-19 02:00:54 UTC (rev 233969)
@@ -1,5 +1,31 @@
2018-07-18 Babak Shafiei <[email protected]>
+ Cherry-pick r233925. rdar://problem/42354959
+
+ Dissociate the VideoFullscreenInterface from its VideoFullscreenModel before removing it from the manager
+ https://bugs.webkit.org/show_bug.cgi?id=187775
+ <rdar://problem/42343229>
+
+ Reviewed by Jon Lee.
+
+ * UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
+ (WebKit::VideoFullscreenManagerProxy::didCleanupFullscreen):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2018-07-18 Jer Noble <[email protected]>
+
+ Dissociate the VideoFullscreenInterface from its VideoFullscreenModel before removing it from the manager
+ https://bugs.webkit.org/show_bug.cgi?id=187775
+ <rdar://problem/42343229>
+
+ Reviewed by Jon Lee.
+
+ * UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
+ (WebKit::VideoFullscreenManagerProxy::didCleanupFullscreen):
+
+2018-07-18 Babak Shafiei <[email protected]>
+
Cherry-pick r233905. rdar://problem/42345236
REGRESSION (iOS 12): Can't scroll to the bottom of the page in WKWebView while keyboard is up on pages with viewport-fit=cover
Modified: branches/safari-606-branch/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm (233968 => 233969)
--- branches/safari-606-branch/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm 2018-07-19 02:00:51 UTC (rev 233968)
+++ branches/safari-606-branch/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm 2018-07-19 02:00:54 UTC (rev 233969)
@@ -609,6 +609,7 @@
m_page->send(Messages::VideoFullscreenManager::DidCleanupFullscreen(contextId), m_page->pageID());
interface->setMode(HTMLMediaElementEnums::VideoFullscreenModeNone);
+ interface->setVideoFullscreenModel(nullptr);
removeClientForContext(contextId);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
