Title: [101348] trunk
- Revision
- 101348
- Author
- [email protected]
- Date
- 2011-11-29 03:00:58 -0800 (Tue, 29 Nov 2011)
Log Message
[Gtk] Regression: Push buttons no longer expose their displayed text/name
https://bugs.webkit.org/show_bug.cgi?id=72804
Reviewed by Chris Fleizach.
Source/WebCore:
Use AccessibilityObject::title() as the last fallback in
webkit_accessible_get_name() right before relying on the
stringValue() method, if no better alternative was found.
Test: platform/gtk/accessibility/button-accessible-name.html
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(webkit_accessible_get_name): Use title() as the last fallback
method before using stringValue().
LayoutTests:
Add new GTK-specific layout test and expections.
* platform/gtk/accessibility/button-accessible-name-expected.txt: Added.
* platform/gtk/accessibility/button-accessible-name.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (101347 => 101348)
--- trunk/LayoutTests/ChangeLog 2011-11-29 10:47:32 UTC (rev 101347)
+++ trunk/LayoutTests/ChangeLog 2011-11-29 11:00:58 UTC (rev 101348)
@@ -1,3 +1,15 @@
+2011-11-29 Mario Sanchez Prada <[email protected]>
+
+ [Gtk] Regression: Push buttons no longer expose their displayed text/name
+ https://bugs.webkit.org/show_bug.cgi?id=72804
+
+ Reviewed by Chris Fleizach.
+
+ Add new GTK-specific layout test and expections.
+
+ * platform/gtk/accessibility/button-accessible-name-expected.txt: Added.
+ * platform/gtk/accessibility/button-accessible-name.html: Added.
+
2011-11-29 Csaba Osztrogonác <[email protected]>
SVG <path> DRT dumps have rounding problems across platforms
Added: trunk/LayoutTests/platform/gtk/accessibility/button-accessible-name-expected.txt (0 => 101348)
--- trunk/LayoutTests/platform/gtk/accessibility/button-accessible-name-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/accessibility/button-accessible-name-expected.txt 2011-11-29 11:00:58 UTC (rev 101348)
@@ -0,0 +1,12 @@
+
+This tests that the text of a button is exposed to Assistive Technologies.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS axButton.role is 'AXRole: push button'
+PASS axButton.title is 'AXTitle: The Button'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/platform/gtk/accessibility/button-accessible-name.html (0 => 101348)
--- trunk/LayoutTests/platform/gtk/accessibility/button-accessible-name.html (rev 0)
+++ trunk/LayoutTests/platform/gtk/accessibility/button-accessible-name.html 2011-11-29 11:00:58 UTC (rev 101348)
@@ -0,0 +1,29 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src=""
+</head>
+<body>
+<form>
+<input id="button" type="submit" value="The Button"/>
+</form>
+<p id="description"></p>
+<div id="console"></div>
+<script>
+description("This tests that the text of a button is exposed to Assistive Technologies.");
+
+if (window.layoutTestController)
+ layoutTestController.dumpAsText();
+
+if (window.accessibilityController) {
+ button = document.getElementById("button");
+ button.focus();
+
+ axButton = accessibilityController.focusedElement;
+ shouldBe("axButton.role", "'AXRole: push button'");
+ shouldBe("axButton.title", "'AXTitle: The Button'");
+}
+</script>
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (101347 => 101348)
--- trunk/Source/WebCore/ChangeLog 2011-11-29 10:47:32 UTC (rev 101347)
+++ trunk/Source/WebCore/ChangeLog 2011-11-29 11:00:58 UTC (rev 101348)
@@ -1,3 +1,20 @@
+2011-11-29 Mario Sanchez Prada <[email protected]>
+
+ [Gtk] Regression: Push buttons no longer expose their displayed text/name
+ https://bugs.webkit.org/show_bug.cgi?id=72804
+
+ Reviewed by Chris Fleizach.
+
+ Use AccessibilityObject::title() as the last fallback in
+ webkit_accessible_get_name() right before relying on the
+ stringValue() method, if no better alternative was found.
+
+ Test: platform/gtk/accessibility/button-accessible-name.html
+
+ * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
+ (webkit_accessible_get_name): Use title() as the last fallback
+ method before using stringValue().
+
2011-11-29 Hyowon Kim <[email protected]>
[Texmap][EFL] Accelerated compositing support using TextureMapper on EFL port
Modified: trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp (101347 => 101348)
--- trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp 2011-11-29 10:47:32 UTC (rev 101347)
+++ trunk/Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp 2011-11-29 11:00:58 UTC (rev 101348)
@@ -206,6 +206,12 @@
return returnString(document->title());
}
+ // Nothing worked so far, try with the AccessibilityObject's
+ // title() before going ahead with stringValue().
+ String axTitle = coreObject->title();
+ if (!axTitle.isEmpty())
+ return returnString(axTitle);
+
return returnString(coreObject->stringValue());
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
