Title: [234023] trunk/Source/WebKit
- Revision
- 234023
- Author
- [email protected]
- Date
- 2018-07-19 21:53:59 -0700 (Thu, 19 Jul 2018)
Log Message
Null pointer dereference under WebPage::autofillLoginCredentials()
https://bugs.webkit.org/show_bug.cgi?id=187823
<rdar://problem/37152195>
Reviewed by David Kilzer.
Deal with m_assistedNode being null under WebPage::autofillLoginCredentials().
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::autofillLoginCredentials):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (234022 => 234023)
--- trunk/Source/WebKit/ChangeLog 2018-07-20 04:47:51 UTC (rev 234022)
+++ trunk/Source/WebKit/ChangeLog 2018-07-20 04:53:59 UTC (rev 234023)
@@ -1,5 +1,18 @@
2018-07-19 Chris Dumez <[email protected]>
+ Null pointer dereference under WebPage::autofillLoginCredentials()
+ https://bugs.webkit.org/show_bug.cgi?id=187823
+ <rdar://problem/37152195>
+
+ Reviewed by David Kilzer.
+
+ Deal with m_assistedNode being null under WebPage::autofillLoginCredentials().
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::autofillLoginCredentials):
+
+2018-07-19 Chris Dumez <[email protected]>
+
[ITP] Crash under ResourceLoadStatisticsMemoryStore::removeDataRecords()
https://bugs.webkit.org/show_bug.cgi?id=187821
<rdar://problem/42112693>
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (234022 => 234023)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2018-07-20 04:47:51 UTC (rev 234022)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2018-07-20 04:53:59 UTC (rev 234023)
@@ -2465,7 +2465,7 @@
void WebPage::autofillLoginCredentials(const String& username, const String& password)
{
- if (is<HTMLInputElement>(*m_assistedNode)) {
+ if (is<HTMLInputElement>(m_assistedNode.get())) {
if (auto autofillElements = AutofillElements::computeAutofillElements(downcast<HTMLInputElement>(*m_assistedNode)))
autofillElements->autofill(username, password);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
