Title: [234032] branches/safari-606-branch/Source/WebCore
Revision
234032
Author
[email protected]
Date
2018-07-20 01:05:47 -0700 (Fri, 20 Jul 2018)

Log Message

Cherry-pick r234007. rdar://problem/42417134

    Ensure DocumentTimeline is kept alive until the VM::whenIdle callback is called
    https://bugs.webkit.org/show_bug.cgi?id=187692

    Reviewed by Ryosuke Niwa.

    Ensure we keep the DocumentTimeline alive until the VM::whenIdle callback is called.

    * animation/DocumentTimeline.cpp:
    (WebCore::DocumentTimeline::currentTime):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-606-branch/Source/WebCore/ChangeLog (234031 => 234032)


--- branches/safari-606-branch/Source/WebCore/ChangeLog	2018-07-20 08:05:45 UTC (rev 234031)
+++ branches/safari-606-branch/Source/WebCore/ChangeLog	2018-07-20 08:05:47 UTC (rev 234032)
@@ -1,5 +1,33 @@
 2018-07-20  Babak Shafiei  <[email protected]>
 
+        Cherry-pick r234007. rdar://problem/42417134
+
+    Ensure DocumentTimeline is kept alive until the VM::whenIdle callback is called
+    https://bugs.webkit.org/show_bug.cgi?id=187692
+    
+    Reviewed by Ryosuke Niwa.
+    
+    Ensure we keep the DocumentTimeline alive until the VM::whenIdle callback is called.
+    
+    * animation/DocumentTimeline.cpp:
+    (WebCore::DocumentTimeline::currentTime):
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2018-07-19  Antoine Quint  <[email protected]>
+
+            Ensure DocumentTimeline is kept alive until the VM::whenIdle callback is called
+            https://bugs.webkit.org/show_bug.cgi?id=187692
+
+            Reviewed by Ryosuke Niwa.
+
+            Ensure we keep the DocumentTimeline alive until the VM::whenIdle callback is called.
+
+            * animation/DocumentTimeline.cpp:
+            (WebCore::DocumentTimeline::currentTime):
+
+2018-07-20  Babak Shafiei  <[email protected]>
+
         Cherry-pick r234005. rdar://problem/42417113
 
     Setting foreground color when editing should take color-filter into account, and report the correct foreground color for collapsed selections

Modified: branches/safari-606-branch/Source/WebCore/animation/DocumentTimeline.cpp (234031 => 234032)


--- branches/safari-606-branch/Source/WebCore/animation/DocumentTimeline.cpp	2018-07-20 08:05:45 UTC (rev 234031)
+++ branches/safari-606-branch/Source/WebCore/animation/DocumentTimeline.cpp	2018-07-20 08:05:47 UTC (rev 234032)
@@ -174,7 +174,7 @@
         // fire syncronously if no JS is running.
         scheduleInvalidationTaskIfNeeded();
         m_waitingOnVMIdle = true;
-        m_document->vm().whenIdle([this]() {
+        m_document->vm().whenIdle([this, protectedThis = makeRefPtr(this)]() {
             m_waitingOnVMIdle = false;
             maybeClearCachedCurrentTime();
         });
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to