Title: [234053] trunk/Source/WebCore
- Revision
- 234053
- Author
- [email protected]
- Date
- 2018-07-20 10:36:57 -0700 (Fri, 20 Jul 2018)
Log Message
Update FrameView::paintContents to use release logging.
https://bugs.webkit.org/show_bug.cgi?id=187854
<rdar://problem/42432371>
Reviewed by Simon Fraser.
Adding release logging helps identifying blank content cases.
* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (234052 => 234053)
--- trunk/Source/WebCore/ChangeLog 2018-07-20 17:33:28 UTC (rev 234052)
+++ trunk/Source/WebCore/ChangeLog 2018-07-20 17:36:57 UTC (rev 234053)
@@ -1,3 +1,16 @@
+2018-07-20 Zalan Bujtas <[email protected]>
+
+ Update FrameView::paintContents to use release logging.
+ https://bugs.webkit.org/show_bug.cgi?id=187854
+ <rdar://problem/42432371>
+
+ Reviewed by Simon Fraser.
+
+ Adding release logging helps identifying blank content cases.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::paintContents):
+
2018-07-20 Jer Noble <[email protected]>
First Auto-PiP from Fullscreen too small & animation blocks
Modified: trunk/Source/WebCore/page/FrameView.cpp (234052 => 234053)
--- trunk/Source/WebCore/page/FrameView.cpp 2018-07-20 17:33:28 UTC (rev 234052)
+++ trunk/Source/WebCore/page/FrameView.cpp 2018-07-20 17:36:57 UTC (rev 234053)
@@ -118,6 +118,8 @@
#include "LegacyTileCache.h"
#endif
+#define RELEASE_LOG_IF_ALLOWED(fmt, ...) RELEASE_LOG_IF(frame().page() && frame().page()->isAlwaysOnLoggingAllowed(), Layout, "%p - FrameView::" fmt, this, ##__VA_ARGS__)
+
namespace WebCore {
using namespace HTMLNames;
@@ -4140,8 +4142,10 @@
return;
ASSERT(!needsLayout());
- if (needsLayout())
+ if (needsLayout()) {
+ RELEASE_LOG_IF_ALLOWED("FrameView::paintContents() - not painting because render tree needs layout (is main frame %d)", frame().isMainFrame());
return;
+ }
PaintingState paintingState;
willPaintContents(context, dirtyRect, paintingState);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
