Title: [234140] trunk/Source/WebCore
- Revision
- 234140
- Author
- [email protected]
- Date
- 2018-07-24 01:55:32 -0700 (Tue, 24 Jul 2018)
Log Message
REGRESSION(r234055): inverted return values in MediaPlayer::wouldTaintOrigin()
https://bugs.webkit.org/show_bug.cgi?id=187944
Reviewed by Carlos Garcia Campos.
The MediaPlayer::wouldTaintOrigin(), as introduced in r234055, should
return false when the URL protocol is `data:`, and should return true
when the given SecurityOrigin cannot access the media URL.
This matches behavior of CanvasRenderingContext::wouldTaintOrigin()
which the new method falls back to when the MediaPlayerPrivate
implementation doesn't or can't determine the would-taint result.
This fixes a bunch of failing and timing-out WebGL test cases on ports
using GStreamer (on which the MediaPlayerPrivate derivate doesn't
implement the wouldTaintOrigin() method).
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::wouldTaintOrigin const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (234139 => 234140)
--- trunk/Source/WebCore/ChangeLog 2018-07-24 08:54:00 UTC (rev 234139)
+++ trunk/Source/WebCore/ChangeLog 2018-07-24 08:55:32 UTC (rev 234140)
@@ -1,5 +1,27 @@
2018-07-24 Zan Dobersek <[email protected]>
+ REGRESSION(r234055): inverted return values in MediaPlayer::wouldTaintOrigin()
+ https://bugs.webkit.org/show_bug.cgi?id=187944
+
+ Reviewed by Carlos Garcia Campos.
+
+ The MediaPlayer::wouldTaintOrigin(), as introduced in r234055, should
+ return false when the URL protocol is `data:`, and should return true
+ when the given SecurityOrigin cannot access the media URL.
+
+ This matches behavior of CanvasRenderingContext::wouldTaintOrigin()
+ which the new method falls back to when the MediaPlayerPrivate
+ implementation doesn't or can't determine the would-taint result.
+
+ This fixes a bunch of failing and timing-out WebGL test cases on ports
+ using GStreamer (on which the MediaPlayerPrivate derivate doesn't
+ implement the wouldTaintOrigin() method).
+
+ * platform/graphics/MediaPlayer.cpp:
+ (WebCore::MediaPlayer::wouldTaintOrigin const):
+
+2018-07-24 Zan Dobersek <[email protected]>
+
[TextureMapper] Separate repaint counter state from debug visuals
https://bugs.webkit.org/show_bug.cgi?id=187946
Modified: trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp (234139 => 234140)
--- trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2018-07-24 08:54:00 UTC (rev 234139)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp 2018-07-24 08:55:32 UTC (rev 234140)
@@ -1053,9 +1053,9 @@
return wouldTaint.value();
if (m_url.protocolIsData())
- return true;
+ return false;
- return origin.canRequest(m_url);
+ return !origin.canRequest(m_url);
}
MediaPlayer::MovieLoadType MediaPlayer::movieLoadType() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
