Title: [234251] trunk/Source/WTF
Revision
234251
Author
[email protected]
Date
2018-07-26 02:00:09 -0700 (Thu, 26 Jul 2018)

Log Message

[WTF] Coverity scan issues
https://bugs.webkit.org/show_bug.cgi?id=186800

Reviewed by Brent Fulgham.

* wtf/CheckedArithmetic.h: Swap the operands to multiply().
* wtf/ThreadSpecific.h: Initialize the m_key variable.
* wtf/dtoa.cpp: Initialize the next variable.

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (234250 => 234251)


--- trunk/Source/WTF/ChangeLog	2018-07-26 08:33:31 UTC (rev 234250)
+++ trunk/Source/WTF/ChangeLog	2018-07-26 09:00:09 UTC (rev 234251)
@@ -1,3 +1,14 @@
+2018-07-26  Tomas Popela  <[email protected]>
+
+        [WTF] Coverity scan issues
+        https://bugs.webkit.org/show_bug.cgi?id=186800
+
+        Reviewed by Brent Fulgham.
+
+        * wtf/CheckedArithmetic.h: Swap the operands to multiply().
+        * wtf/ThreadSpecific.h: Initialize the m_key variable.
+        * wtf/dtoa.cpp: Initialize the next variable.
+
 2018-07-25  Tomas Popela  <[email protected]>
 
         Correctly close the variable argument list

Modified: trunk/Source/WTF/wtf/CheckedArithmetic.h (234250 => 234251)


--- trunk/Source/WTF/wtf/CheckedArithmetic.h	2018-07-26 08:33:31 UTC (rev 234250)
+++ trunk/Source/WTF/wtf/CheckedArithmetic.h	2018-07-26 09:00:09 UTC (rev 234251)
@@ -489,7 +489,7 @@
 
     static inline bool multiply(int64_t lhs, int64_t rhs, ResultType& result)
     {
-        return ArithmeticOperations<int, unsigned, ResultType>::multiply(rhs, lhs, result);
+        return ArithmeticOperations<int, unsigned, ResultType>::multiply(lhs, rhs, result);
     }
 
     static inline bool equals(unsigned lhs, int rhs)

Modified: trunk/Source/WTF/wtf/ThreadSpecific.h (234250 => 234251)


--- trunk/Source/WTF/wtf/ThreadSpecific.h	2018-07-26 08:33:31 UTC (rev 234250)
+++ trunk/Source/WTF/wtf/ThreadSpecific.h	2018-07-26 09:00:09 UTC (rev 234251)
@@ -122,7 +122,7 @@
     void static THREAD_SPECIFIC_CALL destroy(void* ptr);
 
 #if USE(PTHREADS)
-    pthread_key_t m_key;
+    pthread_key_t m_key { };
 #elif OS(WINDOWS)
     int m_index;
 #endif

Modified: trunk/Source/WTF/wtf/dtoa.cpp (234250 => 234251)


--- trunk/Source/WTF/wtf/dtoa.cpp	2018-07-26 08:33:31 UTC (rev 234250)
+++ trunk/Source/WTF/wtf/dtoa.cpp	2018-07-26 09:00:09 UTC (rev 234251)
@@ -360,7 +360,7 @@
 public:
     P5Node() { }
     BigInt val;
-    P5Node* next;
+    P5Node* next { nullptr };
 };
 
 static P5Node* p5s;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to