Title: [234253] trunk/Source/WebCore
- Revision
- 234253
- Author
- [email protected]
- Date
- 2018-07-26 06:45:33 -0700 (Thu, 26 Jul 2018)
Log Message
[LFC][BFC] assert-not-implemented-yet on inflow non-replaced height when style is not fixed/auto.
https://bugs.webkit.org/show_bug.cgi?id=187969
Reviewed by Antti Koivisto.
Assert on unsupported height types when computing inflow non-replaced height.
* layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (234252 => 234253)
--- trunk/Source/WebCore/ChangeLog 2018-07-26 09:30:22 UTC (rev 234252)
+++ trunk/Source/WebCore/ChangeLog 2018-07-26 13:45:33 UTC (rev 234253)
@@ -1,3 +1,15 @@
+2018-07-26 Zalan Bujtas <[email protected]>
+
+ [LFC][BFC] assert-not-implemented-yet on inflow non-replaced height when style is not fixed/auto.
+ https://bugs.webkit.org/show_bug.cgi?id=187969
+
+ Reviewed by Antti Koivisto.
+
+ Assert on unsupported height types when computing inflow non-replaced height.
+
+ * layout/blockformatting/BlockFormattingContextGeometry.cpp:
+ (WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
+
2018-07-26 Antoine Quint <[email protected]>
[Web Animations] REGRESSION: transition added immediately after element creation doesn't work
Modified: trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp (234252 => 234253)
--- trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp 2018-07-26 09:30:22 UTC (rev 234252)
+++ trunk/Source/WebCore/layout/blockformatting/BlockFormattingContextGeometry.cpp 2018-07-26 13:45:33 UTC (rev 234253)
@@ -85,9 +85,15 @@
VerticalEdges collapsedMargin = { MarginCollapse::marginTop(layoutContext, layoutBox), MarginCollapse::marginBottom(layoutContext, layoutBox) };
auto borderAndPaddingTop = displayBox.borderTop() + displayBox.paddingTop();
- if (!style.logicalHeight().isAuto())
- return { style.logicalHeight().value(), nonCollapsedMargin, collapsedMargin };
+ auto height = style.logicalHeight();
+ if (!height.isAuto()) {
+ if (height.isFixed())
+ return { style.logicalHeight().value(), nonCollapsedMargin, collapsedMargin };
+ // Most notably height percentage.
+ ASSERT_NOT_IMPLEMENTED_YET();
+ }
+
if (!is<Container>(layoutBox) || !downcast<Container>(layoutBox).hasInFlowChild())
return { 0, nonCollapsedMargin, collapsedMargin };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
