Title: [234262] trunk/Source/WebKit
- Revision
- 234262
- Author
- [email protected]
- Date
- 2018-07-26 09:59:17 -0700 (Thu, 26 Jul 2018)
Log Message
Disable Dark Mode in the Plugin process to avoid rendering issues
https://bugs.webkit.org/show_bug.cgi?id=188059
<rdar://problem/42369281>
Reviewed by Tim Horton.
Plugins generally do not support dark mode and this causes rendering issues so
disable dark mode in the plugin process.
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::platformInitializePluginProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (234261 => 234262)
--- trunk/Source/WebKit/ChangeLog 2018-07-26 16:15:30 UTC (rev 234261)
+++ trunk/Source/WebKit/ChangeLog 2018-07-26 16:59:17 UTC (rev 234262)
@@ -1,5 +1,19 @@
2018-07-26 Chris Dumez <[email protected]>
+ Disable Dark Mode in the Plugin process to avoid rendering issues
+ https://bugs.webkit.org/show_bug.cgi?id=188059
+ <rdar://problem/42369281>
+
+ Reviewed by Tim Horton.
+
+ Plugins generally do not support dark mode and this causes rendering issues so
+ disable dark mode in the plugin process.
+
+ * PluginProcess/mac/PluginProcessMac.mm:
+ (WebKit::PluginProcess::platformInitializePluginProcess):
+
+2018-07-26 Chris Dumez <[email protected]>
+
WebSiteData-related methods should take in CompletionHandlers instead of Functions
https://bugs.webkit.org/show_bug.cgi?id=188027
Modified: trunk/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm (234261 => 234262)
--- trunk/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm 2018-07-26 16:15:30 UTC (rev 234261)
+++ trunk/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm 2018-07-26 16:59:17 UTC (rev 234262)
@@ -521,6 +521,11 @@
initWithMemoryCapacity:pluginMemoryCacheSize
diskCapacity:pluginDiskCacheSize
diskPath:m_nsurlCacheDirectory]).get()];
+
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
+ // Disable Dark Mode in the plugin process to avoid rendering issues.
+ [NSApp setAppearance:[NSAppearance appearanceNamed:NSAppearanceNameAqua]];
+#endif
}
void PluginProcess::platformInitializeProcess(const ChildProcessInitializationParameters& parameters)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
