Title: [234265] trunk/Source/WebKit
Revision
234265
Author
[email protected]
Date
2018-07-26 10:04:52 -0700 (Thu, 26 Jul 2018)

Log Message

Remove a forward protocol declaration of '_WKWebViewPrintProvider'
https://bugs.webkit.org/show_bug.cgi?id=188012
<rdar://problem/42309526>

Reviewed by Darin Adler.

@procotol() expressions emit invalid protocol metadata when used with forward @protocol declarations.
Clang is going to make it an error for using a forward-declared protocol in a @protocol _expression_, so
we need to stop doing this.

* UIProcess/API/Cocoa/WKWebViewInternal.h:

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (234264 => 234265)


--- trunk/Source/WebKit/ChangeLog	2018-07-26 17:03:39 UTC (rev 234264)
+++ trunk/Source/WebKit/ChangeLog	2018-07-26 17:04:52 UTC (rev 234265)
@@ -1,3 +1,17 @@
+2018-07-26  Sihui Liu  <[email protected]>
+
+        Remove a forward protocol declaration of '_WKWebViewPrintProvider'
+        https://bugs.webkit.org/show_bug.cgi?id=188012
+        <rdar://problem/42309526>
+
+        Reviewed by Darin Adler.
+
+        @procotol() expressions emit invalid protocol metadata when used with forward @protocol declarations. 
+        Clang is going to make it an error for using a forward-declared protocol in a @protocol _expression_, so
+        we need to stop doing this.
+
+        * UIProcess/API/Cocoa/WKWebViewInternal.h:
+
 2018-07-26  Chris Dumez  <[email protected]>
 
         Disable Dark Mode in the Plugin process to avoid rendering issues

Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h (234264 => 234265)


--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h	2018-07-26 17:03:39 UTC (rev 234264)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h	2018-07-26 17:04:52 UTC (rev 234265)
@@ -30,6 +30,7 @@
 #import "SameDocumentNavigationType.h"
 #import "WKWebViewConfiguration.h"
 #import "_WKAttachmentInternal.h"
+#import "_WKWebViewPrintFormatterInternal.h"
 #import <wtf/RefPtr.h>
 #import <wtf/RetainPtr.h>
 
@@ -61,7 +62,6 @@
 @class WKWebViewContentProviderRegistry;
 @class WKPasswordView;
 @class _WKFrameHandle;
-@protocol _WKWebViewPrintProvider;
 
 @interface WKWebView () WK_WEB_VIEW_PROTOCOLS {
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to