Title: [234295] branches/safari-606-branch/Source/WebKit
- Revision
- 234295
- Author
- [email protected]
- Date
- 2018-07-26 23:01:48 -0700 (Thu, 26 Jul 2018)
Log Message
Cherry-pick r233925. rdar://problem/42354959
Dissociate the VideoFullscreenInterface from its VideoFullscreenModel before removing it from the manager
https://bugs.webkit.org/show_bug.cgi?id=187775
<rdar://problem/42343229>
Reviewed by Jon Lee.
* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
(WebKit::VideoFullscreenManagerProxy::didCleanupFullscreen):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-606-branch/Source/WebKit/ChangeLog (234294 => 234295)
--- branches/safari-606-branch/Source/WebKit/ChangeLog 2018-07-27 05:25:23 UTC (rev 234294)
+++ branches/safari-606-branch/Source/WebKit/ChangeLog 2018-07-27 06:01:48 UTC (rev 234295)
@@ -1,5 +1,31 @@
2018-07-26 Babak Shafiei <[email protected]>
+ Cherry-pick r233925. rdar://problem/42354959
+
+ Dissociate the VideoFullscreenInterface from its VideoFullscreenModel before removing it from the manager
+ https://bugs.webkit.org/show_bug.cgi?id=187775
+ <rdar://problem/42343229>
+
+ Reviewed by Jon Lee.
+
+ * UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
+ (WebKit::VideoFullscreenManagerProxy::didCleanupFullscreen):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2018-07-18 Jer Noble <[email protected]>
+
+ Dissociate the VideoFullscreenInterface from its VideoFullscreenModel before removing it from the manager
+ https://bugs.webkit.org/show_bug.cgi?id=187775
+ <rdar://problem/42343229>
+
+ Reviewed by Jon Lee.
+
+ * UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
+ (WebKit::VideoFullscreenManagerProxy::didCleanupFullscreen):
+
+2018-07-26 Babak Shafiei <[email protected]>
+
Cherry-pick r234272. rdar://problem/42645434
Unreviewed, rolling out r234181 and r234189.
Modified: branches/safari-606-branch/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm (234294 => 234295)
--- branches/safari-606-branch/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm 2018-07-27 05:25:23 UTC (rev 234294)
+++ branches/safari-606-branch/Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm 2018-07-27 06:01:48 UTC (rev 234295)
@@ -609,6 +609,7 @@
m_page->send(Messages::VideoFullscreenManager::DidCleanupFullscreen(contextId), m_page->pageID());
interface->setMode(HTMLMediaElementEnums::VideoFullscreenModeNone);
+ interface->setVideoFullscreenModel(nullptr);
removeClientForContext(contextId);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes