Title: [234304] branches/safari-606-branch/Source/WebKit
Revision
234304
Author
[email protected]
Date
2018-07-26 23:02:17 -0700 (Thu, 26 Jul 2018)

Log Message

Cherry-pick r234262. rdar://problem/42650389

    Disable Dark Mode in the Plugin process to avoid rendering issues
    https://bugs.webkit.org/show_bug.cgi?id=188059
    <rdar://problem/42369281>

    Reviewed by Tim Horton.

    Plugins generally do not support dark mode and this causes rendering issues so
    disable dark mode in the plugin process.

    * PluginProcess/mac/PluginProcessMac.mm:
    (WebKit::PluginProcess::platformInitializePluginProcess):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-606-branch/Source/WebKit/ChangeLog (234303 => 234304)


--- branches/safari-606-branch/Source/WebKit/ChangeLog	2018-07-27 06:02:14 UTC (rev 234303)
+++ branches/safari-606-branch/Source/WebKit/ChangeLog	2018-07-27 06:02:17 UTC (rev 234304)
@@ -1,5 +1,38 @@
 2018-07-26  Babak Shafiei  <[email protected]>
 
+        Cherry-pick r234262. rdar://problem/42650389
+
+    Disable Dark Mode in the Plugin process to avoid rendering issues
+    https://bugs.webkit.org/show_bug.cgi?id=188059
+    <rdar://problem/42369281>
+    
+    Reviewed by Tim Horton.
+    
+    Plugins generally do not support dark mode and this causes rendering issues so
+    disable dark mode in the plugin process.
+    
+    * PluginProcess/mac/PluginProcessMac.mm:
+    (WebKit::PluginProcess::platformInitializePluginProcess):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2018-07-26  Chris Dumez  <[email protected]>
+
+            Disable Dark Mode in the Plugin process to avoid rendering issues
+            https://bugs.webkit.org/show_bug.cgi?id=188059
+            <rdar://problem/42369281>
+
+            Reviewed by Tim Horton.
+
+            Plugins generally do not support dark mode and this causes rendering issues so
+            disable dark mode in the plugin process.
+
+            * PluginProcess/mac/PluginProcessMac.mm:
+            (WebKit::PluginProcess::platformInitializePluginProcess):
+
+2018-07-26  Babak Shafiei  <[email protected]>
+
         Cherry-pick r234223. rdar://problem/42650367
 
     [macOS] Update sandboxes for revised OpenCL calls and streaming media

Modified: branches/safari-606-branch/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm (234303 => 234304)


--- branches/safari-606-branch/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm	2018-07-27 06:02:14 UTC (rev 234303)
+++ branches/safari-606-branch/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm	2018-07-27 06:02:17 UTC (rev 234304)
@@ -520,6 +520,11 @@
         initWithMemoryCapacity:pluginMemoryCacheSize
         diskCapacity:pluginDiskCacheSize
         diskPath:m_nsurlCacheDirectory]).get()];
+
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
+    // Disable Dark Mode in the plugin process to avoid rendering issues.
+    [NSApp setAppearance:[NSAppearance appearanceNamed:NSAppearanceNameAqua]];
+#endif
 }
 
 void PluginProcess::platformInitializeProcess(const ChildProcessInitializationParameters& parameters)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to