Title: [234345] trunk/Source/WebCore
Revision
234345
Author
[email protected]
Date
2018-07-28 11:39:58 -0700 (Sat, 28 Jul 2018)

Log Message

Reset CompositingPolicyOverride between tests
https://bugs.webkit.org/show_bug.cgi?id=188138

Reviewed by Zalan Bujtas.

WK1 tests were failing after r234330 because the compositing policy override optional
was left set on the Page (WK1 has injected bundle SPI to clear it). Fix by having
Internals::resetToConsistentState clear this state.

* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (234344 => 234345)


--- trunk/Source/WebCore/ChangeLog	2018-07-28 16:35:24 UTC (rev 234344)
+++ trunk/Source/WebCore/ChangeLog	2018-07-28 18:39:58 UTC (rev 234345)
@@ -1,3 +1,17 @@
+2018-07-28  Simon Fraser  <[email protected]>
+
+        Reset CompositingPolicyOverride between tests
+        https://bugs.webkit.org/show_bug.cgi?id=188138
+
+        Reviewed by Zalan Bujtas.
+
+        WK1 tests were failing after r234330 because the compositing policy override optional
+        was left set on the Page (WK1 has injected bundle SPI to clear it). Fix by having 
+        Internals::resetToConsistentState clear this state.
+
+        * testing/Internals.cpp:
+        (WebCore::Internals::resetToConsistentState):
+
 2018-07-24  Simon Fraser  <[email protected]>
 
         Animation stops with object-fit:contain on an animated 2d canvas

Modified: trunk/Source/WebCore/testing/Internals.cpp (234344 => 234345)


--- trunk/Source/WebCore/testing/Internals.cpp	2018-07-28 16:35:24 UTC (rev 234344)
+++ trunk/Source/WebCore/testing/Internals.cpp	2018-07-28 18:39:58 UTC (rev 234345)
@@ -438,6 +438,8 @@
 
     page.mainFrame().setTextZoomFactor(1.0f);
 
+    page.setCompositingPolicyOverride(std::nullopt);
+
     FrameView* mainFrameView = page.mainFrame().view();
     if (mainFrameView) {
         mainFrameView->setHeaderHeight(0);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to