Title: [234357] branches/safari-606-branch/Source/WebCore
Revision
234357
Author
[email protected]
Date
2018-07-29 23:28:26 -0700 (Sun, 29 Jul 2018)

Log Message

Cherry-pick r234345. rdar://problem/42721217

    Reset CompositingPolicyOverride between tests
    https://bugs.webkit.org/show_bug.cgi?id=188138

    Reviewed by Zalan Bujtas.

    WK1 tests were failing after r234330 because the compositing policy override optional
    was left set on the Page (WK1 has injected bundle SPI to clear it). Fix by having
    Internals::resetToConsistentState clear this state.

    * testing/Internals.cpp:
    (WebCore::Internals::resetToConsistentState):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-606-branch/Source/WebCore/ChangeLog (234356 => 234357)


--- branches/safari-606-branch/Source/WebCore/ChangeLog	2018-07-30 06:28:23 UTC (rev 234356)
+++ branches/safari-606-branch/Source/WebCore/ChangeLog	2018-07-30 06:28:26 UTC (rev 234357)
@@ -1,5 +1,38 @@
 2018-07-29  Babak Shafiei  <[email protected]>
 
+        Cherry-pick r234345. rdar://problem/42721217
+
+    Reset CompositingPolicyOverride between tests
+    https://bugs.webkit.org/show_bug.cgi?id=188138
+    
+    Reviewed by Zalan Bujtas.
+    
+    WK1 tests were failing after r234330 because the compositing policy override optional
+    was left set on the Page (WK1 has injected bundle SPI to clear it). Fix by having
+    Internals::resetToConsistentState clear this state.
+    
+    * testing/Internals.cpp:
+    (WebCore::Internals::resetToConsistentState):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2018-07-28  Simon Fraser  <[email protected]>
+
+            Reset CompositingPolicyOverride between tests
+            https://bugs.webkit.org/show_bug.cgi?id=188138
+
+            Reviewed by Zalan Bujtas.
+
+            WK1 tests were failing after r234330 because the compositing policy override optional
+            was left set on the Page (WK1 has injected bundle SPI to clear it). Fix by having
+            Internals::resetToConsistentState clear this state.
+
+            * testing/Internals.cpp:
+            (WebCore::Internals::resetToConsistentState):
+
+2018-07-29  Babak Shafiei  <[email protected]>
+
         Cherry-pick r234340. rdar://problem/42721208
 
     Adjust the color matrix for the inverse apple-invert-lightness() transformation

Modified: branches/safari-606-branch/Source/WebCore/testing/Internals.cpp (234356 => 234357)


--- branches/safari-606-branch/Source/WebCore/testing/Internals.cpp	2018-07-30 06:28:23 UTC (rev 234356)
+++ branches/safari-606-branch/Source/WebCore/testing/Internals.cpp	2018-07-30 06:28:26 UTC (rev 234357)
@@ -438,6 +438,8 @@
 
     page.mainFrame().setTextZoomFactor(1.0f);
 
+    page.setCompositingPolicyOverride(std::nullopt);
+
     FrameView* mainFrameView = page.mainFrame().view();
     if (mainFrameView) {
         mainFrameView->setHeaderHeight(0);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to