Title: [234372] branches/safari-606-branch/Source/WebCore
- Revision
- 234372
- Author
- [email protected]
- Date
- 2018-07-30 10:16:22 -0700 (Mon, 30 Jul 2018)
Log Message
Cherry-pick r234339. rdar://problem/42736275
[iOS] Don't deactivate audio session
https://bugs.webkit.org/show_bug.cgi?id=188127
<rdar://problem/42544143>
Reviewed by Jon Lee.
r233435 includes a change that deactivates the shared audio session when there are no more
active media sessions. This is a good in WK2 because it allows other applications to resume
playing audio when WebKit stops playing, but it is potentially bad in WK1 where the host
app may also be playing audio.
* platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::removeSession): Don't deactivate the audio session.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-606-branch/Source/WebCore/ChangeLog (234371 => 234372)
--- branches/safari-606-branch/Source/WebCore/ChangeLog 2018-07-30 17:14:11 UTC (rev 234371)
+++ branches/safari-606-branch/Source/WebCore/ChangeLog 2018-07-30 17:16:22 UTC (rev 234372)
@@ -1,3 +1,40 @@
+2018-07-30 Babak Shafiei <[email protected]>
+
+ Cherry-pick r234339. rdar://problem/42736275
+
+ [iOS] Don't deactivate audio session
+ https://bugs.webkit.org/show_bug.cgi?id=188127
+ <rdar://problem/42544143>
+
+ Reviewed by Jon Lee.
+
+ r233435 includes a change that deactivates the shared audio session when there are no more
+ active media sessions. This is a good in WK2 because it allows other applications to resume
+ playing audio when WebKit stops playing, but it is potentially bad in WK1 where the host
+ app may also be playing audio.
+
+ * platform/audio/PlatformMediaSessionManager.cpp:
+ (WebCore::PlatformMediaSessionManager::removeSession): Don't deactivate the audio session.
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2018-07-27 Eric Carlson <[email protected]>
+
+ [iOS] Don't deactivate audio session
+ https://bugs.webkit.org/show_bug.cgi?id=188127
+ <rdar://problem/42544143>
+
+ Reviewed by Jon Lee.
+
+ r233435 includes a change that deactivates the shared audio session when there are no more
+ active media sessions. This is a good in WK2 because it allows other applications to resume
+ playing audio when WebKit stops playing, but it is potentially bad in WK1 where the host
+ app may also be playing audio.
+
+ * platform/audio/PlatformMediaSessionManager.cpp:
+ (WebCore::PlatformMediaSessionManager::removeSession): Don't deactivate the audio session.
+
2018-07-29 Babak Shafiei <[email protected]>
Cherry-pick r234345. rdar://problem/42721217
Modified: branches/safari-606-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp (234371 => 234372)
--- branches/safari-606-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp 2018-07-30 17:14:11 UTC (rev 234371)
+++ branches/safari-606-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp 2018-07-30 17:16:22 UTC (rev 234372)
@@ -162,9 +162,6 @@
if (m_sessions.isEmpty() || std::all_of(m_sessions.begin(), m_sessions.end(), std::logical_not<void>())) {
m_remoteCommandListener = nullptr;
m_audioHardwareListener = nullptr;
-#if USE(AUDIO_SESSION)
- AudioSession::sharedSession().tryToSetActive(false);
-#endif
}
scheduleUpdateSessionState();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
