Title: [234422] trunk/Source
- Revision
- 234422
- Author
- [email protected]
- Date
- 2018-07-31 05:01:48 -0700 (Tue, 31 Jul 2018)
Log Message
Remove ResourceResponse::cacheBodyKey API
https://bugs.webkit.org/show_bug.cgi?id=188192
Patch by Rob Buis <[email protected]> on 2018-07-31
Reviewed by Frédéric Wang.
Source/WebCore:
Removed unused API.
No new tests needed since this API is not used.
* platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::encode const):
(WebCore::ResourceResponseBase::decode):
(WebCore::ResourceResponseBase::cacheBodyKey const): Deleted.
(WebCore::ResourceResponseBase::setCacheBodyKey): Deleted.
Source/WebKit:
Remove unused API.
* NetworkProcess/cache/NetworkCacheEntry.cpp:
(WebKit::NetworkCache::Entry::decodeStorageRecord):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (234421 => 234422)
--- trunk/Source/WebCore/ChangeLog 2018-07-31 10:39:36 UTC (rev 234421)
+++ trunk/Source/WebCore/ChangeLog 2018-07-31 12:01:48 UTC (rev 234422)
@@ -1,3 +1,20 @@
+2018-07-31 Rob Buis <[email protected]>
+
+ Remove ResourceResponse::cacheBodyKey API
+ https://bugs.webkit.org/show_bug.cgi?id=188192
+
+ Reviewed by Frédéric Wang.
+
+ Removed unused API.
+
+ No new tests needed since this API is not used.
+
+ * platform/network/ResourceResponseBase.h:
+ (WebCore::ResourceResponseBase::encode const):
+ (WebCore::ResourceResponseBase::decode):
+ (WebCore::ResourceResponseBase::cacheBodyKey const): Deleted.
+ (WebCore::ResourceResponseBase::setCacheBodyKey): Deleted.
+
2018-07-30 Simon Fraser <[email protected]>
Shrink GraphicsLayerCA
Modified: trunk/Source/WebCore/platform/network/ResourceResponseBase.h (234421 => 234422)
--- trunk/Source/WebCore/platform/network/ResourceResponseBase.h 2018-07-31 10:39:36 UTC (rev 234421)
+++ trunk/Source/WebCore/platform/network/ResourceResponseBase.h 2018-07-31 12:01:48 UTC (rev 234422)
@@ -32,7 +32,6 @@
#include "NetworkLoadMetrics.h"
#include "ParsedContentRange.h"
#include "URL.h"
-#include <wtf/SHA1.h>
#include <wtf/WallTime.h>
namespace WebCore {
@@ -150,9 +149,6 @@
m_source = source;
}
- const std::optional<SHA1::Digest>& cacheBodyKey() const { return m_cacheBodyKey; }
- void setCacheBodyKey(const SHA1::Digest& key) { m_cacheBodyKey = key; }
-
// FIXME: This should be eliminated from ResourceResponse.
// Network loading metrics should be delivered via didFinishLoad
// and should not be part of the ResourceResponse.
@@ -224,7 +220,6 @@
mutable std::optional<WallTime> m_lastModified;
mutable ParsedContentRange m_contentRange;
mutable CacheControlDirectives m_cacheControlDirectives;
- std::optional<SHA1::Digest> m_cacheBodyKey;
mutable bool m_haveParsedCacheControlHeader { false };
mutable bool m_haveParsedAgeHeader { false };
@@ -270,7 +265,6 @@
encoder << m_httpStatusCode;
encoder << m_certificateInfo;
encoder.encodeEnum(m_source);
- encoder << m_cacheBodyKey;
encoder.encodeEnum(m_type);
encoder.encodeEnum(m_tainting);
encoder << m_isRedirected;
@@ -311,8 +305,6 @@
return false;
if (!decoder.decodeEnum(response.m_source))
return false;
- if (!decoder.decode(response.m_cacheBodyKey))
- return false;
if (!decoder.decodeEnum(response.m_type))
return false;
if (!decoder.decodeEnum(response.m_tainting))
Modified: trunk/Source/WebKit/ChangeLog (234421 => 234422)
--- trunk/Source/WebKit/ChangeLog 2018-07-31 10:39:36 UTC (rev 234421)
+++ trunk/Source/WebKit/ChangeLog 2018-07-31 12:01:48 UTC (rev 234422)
@@ -1,3 +1,15 @@
+2018-07-31 Rob Buis <[email protected]>
+
+ Remove ResourceResponse::cacheBodyKey API
+ https://bugs.webkit.org/show_bug.cgi?id=188192
+
+ Reviewed by Frédéric Wang.
+
+ Remove unused API.
+
+ * NetworkProcess/cache/NetworkCacheEntry.cpp:
+ (WebKit::NetworkCache::Entry::decodeStorageRecord):
+
2018-07-30 Sihui Liu <[email protected]>
Add support for fetching and remove type _WKWebsiteDataTypeHSTSCache
Modified: trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.cpp (234421 => 234422)
--- trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.cpp 2018-07-31 10:39:36 UTC (rev 234421)
+++ trunk/Source/WebKit/NetworkProcess/cache/NetworkCacheEntry.cpp 2018-07-31 12:01:48 UTC (rev 234422)
@@ -113,8 +113,6 @@
if (!decoder.decode(entry->m_response))
return nullptr;
entry->m_response.setSource(WebCore::ResourceResponse::Source::DiskCache);
- if (storageEntry.bodyHash)
- entry->m_response.setCacheBodyKey(*storageEntry.bodyHash);
bool hasVaryingRequestHeaders;
if (!decoder.decode(hasVaryingRequestHeaders))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
