Title: [234444] trunk/Source/WebCore
- Revision
- 234444
- Author
- [email protected]
- Date
- 2018-07-31 19:29:23 -0700 (Tue, 31 Jul 2018)
Log Message
[Cocoa] Addressing post-review comments on r234158
https://bugs.webkit.org/show_bug.cgi?id=188202
Reviewed by Darin Adler.
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::lastResortFallbackFont):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (234443 => 234444)
--- trunk/Source/WebCore/ChangeLog 2018-08-01 02:15:51 UTC (rev 234443)
+++ trunk/Source/WebCore/ChangeLog 2018-08-01 02:29:23 UTC (rev 234444)
@@ -1,3 +1,13 @@
+2018-07-31 Myles C. Maxfield <[email protected]>
+
+ [Cocoa] Addressing post-review comments on r234158
+ https://bugs.webkit.org/show_bug.cgi?id=188202
+
+ Reviewed by Darin Adler.
+
+ * platform/graphics/cocoa/FontCacheCoreText.cpp:
+ (WebCore::FontCache::lastResortFallbackFont):
+
2018-07-31 John Wilander <[email protected]>
Resource Load Statistics: Remove partitioned cookies for reduced complexity, lower memory footprint, and ability to support more platforms
Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp (234443 => 234444)
--- trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp 2018-08-01 02:15:51 UTC (rev 234443)
+++ trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp 2018-08-01 02:29:23 UTC (rev 234444)
@@ -1484,11 +1484,6 @@
if (auto result = fontForFamily(fontDescription, AtomicString("Times", AtomicString::ConstructFromLiteral)))
return *result;
- // The Times fallback will almost always work, but in the highly unusual case where
- // the user doesn't have it, we fall back on Lucida Grande.
- if (auto result = fontForFamily(fontDescription, AtomicString("Lucida Grande", AtomicString::ConstructFromLiteral), nullptr, nullptr, { }, false))
- return *result;
-
// LastResort is guaranteed to be non-null.
#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 110000) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101300)
auto fontDescriptor = adoptCF(CTFontDescriptorCreateLastResort());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
