Title: [234544] trunk/Source/WebCore
- Revision
- 234544
- Author
- [email protected]
- Date
- 2018-08-03 07:21:21 -0700 (Fri, 03 Aug 2018)
Log Message
[LFC] Do not check margin box while validating geometry.
https://bugs.webkit.org/show_bug.cgi?id=188297
Reviewed by Antti Koivisto.
The current RenderBox::marginBox implementation is not spec compliant. Ignore it for now.
* layout/Verification.cpp:
(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (234543 => 234544)
--- trunk/Source/WebCore/ChangeLog 2018-08-03 10:43:14 UTC (rev 234543)
+++ trunk/Source/WebCore/ChangeLog 2018-08-03 14:21:21 UTC (rev 234544)
@@ -1,3 +1,15 @@
+2018-08-03 Zalan Bujtas <[email protected]>
+
+ [LFC] Do not check margin box while validating geometry.
+ https://bugs.webkit.org/show_bug.cgi?id=188297
+
+ Reviewed by Antti Koivisto.
+
+ The current RenderBox::marginBox implementation is not spec compliant. Ignore it for now.
+
+ * layout/Verification.cpp:
+ (WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):
+
2018-08-03 Carlos Garcia Campos <[email protected]>
[WPE] Use WPE key symbols and new API instead of xkbcommon and the key mapper
Modified: trunk/Source/WebCore/layout/Verification.cpp (234543 => 234544)
--- trunk/Source/WebCore/layout/Verification.cpp 2018-08-03 10:43:14 UTC (rev 234543)
+++ trunk/Source/WebCore/layout/Verification.cpp 2018-08-03 14:21:21 UTC (rev 234544)
@@ -134,11 +134,6 @@
return true;
}
- if (renderer.marginBoxRect() != displayBox->nonCollapsedMarginBox()) {
- outputRect("marginBox", renderer.marginBoxRect(), displayBox->nonCollapsedMarginBox());
- return true;
- }
-
if (renderer.borderBoxRect() != displayBox->borderBox()) {
outputRect("borderBox", renderer.borderBoxRect(), displayBox->borderBox());
return true;
@@ -154,6 +149,7 @@
return true;
}
+ // TODO: The RenderBox::marginBox() does not follow the spec and ignores certain constraints. Skip them for now.
return false;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
