Title: [234555] trunk/Source/WebDriver
- Revision
- 234555
- Author
- [email protected]
- Date
- 2018-08-03 11:36:31 -0700 (Fri, 03 Aug 2018)
Log Message
Fix invalid optional access in WebDriver Session::createTopLevelBrowsingContext.
https://bugs.webkit.org/show_bug.cgi?id=188304
Reviewed by Brian Burg.
* Session.cpp:
(WebDriver::Session::createTopLevelBrowsingContext): remove incorrect value() call.
Modified Paths
Diff
Modified: trunk/Source/WebDriver/ChangeLog (234554 => 234555)
--- trunk/Source/WebDriver/ChangeLog 2018-08-03 18:00:23 UTC (rev 234554)
+++ trunk/Source/WebDriver/ChangeLog 2018-08-03 18:36:31 UTC (rev 234555)
@@ -1,3 +1,13 @@
+2018-08-03 Ms2ger <[email protected]>
+
+ Fix invalid optional access in WebDriver Session::createTopLevelBrowsingContext.
+ https://bugs.webkit.org/show_bug.cgi?id=188304
+
+ Reviewed by Brian Burg.
+
+ * Session.cpp:
+ (WebDriver::Session::createTopLevelBrowsingContext): remove incorrect value() call.
+
2018-07-26 Ross Kirsling <[email protected]>
String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
Modified: trunk/Source/WebDriver/Session.cpp (234554 => 234555)
--- trunk/Source/WebDriver/Session.cpp 2018-08-03 18:00:23 UTC (rev 234554)
+++ trunk/Source/WebDriver/Session.cpp 2018-08-03 18:36:31 UTC (rev 234555)
@@ -177,7 +177,7 @@
void Session::createTopLevelBrowsingContext(Function<void (CommandResult&&)>&& completionHandler)
{
- ASSERT(!m_toplevelBrowsingContext.value());
+ ASSERT(!m_toplevelBrowsingContext);
m_host->sendCommandToBackend("createBrowsingContext"_s, nullptr, [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) mutable {
if (response.isError || !response.responseObject) {
completionHandler(CommandResult::fail(WTFMove(response.responseObject)));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
