Diff
Modified: trunk/Source/_javascript_Core/API/JSExport.h (234562 => 234563)
--- trunk/Source/_javascript_Core/API/JSExport.h 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/_javascript_Core/API/JSExport.h 2018-08-03 23:13:57 UTC (rev 234563)
@@ -124,7 +124,7 @@
- Any lowercase letter that had followed a colon will be capitalized.
Under the default conversion a selector <code>doFoo:withBar:</code> will be exported as
- <code>doFooWithBar</code>. The default conversion may be overriden using the JSExportAs
+ <code>doFooWithBar</code>. The default conversion may be overridden using the JSExportAs
macro, for example to export a method <code>doFoo:withBar:</code> as <code>doFoo</code>:
<pre>
Modified: trunk/Source/_javascript_Core/ChangeLog (234562 => 234563)
--- trunk/Source/_javascript_Core/ChangeLog 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-08-03 23:13:57 UTC (rev 234563)
@@ -1,3 +1,13 @@
+2018-08-03 Alex Christensen <[email protected]>
+
+ Fix spelling of "overridden"
+ https://bugs.webkit.org/show_bug.cgi?id=188315
+
+ Reviewed by Darin Adler.
+
+ * API/JSExport.h:
+ * inspector/InjectedScriptSource.js:
+
2018-08-02 Saam Barati <[email protected]>
Reading instructionPointer from PlatformRegisters may fail when using pointer profiling
Modified: trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js (234562 => 234563)
--- trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js 2018-08-03 23:13:57 UTC (rev 234563)
@@ -31,7 +31,7 @@
(function (InjectedScriptHost, inspectedGlobalObject, injectedScriptId) {
-// FIXME: <https://webkit.org/b/152294> Web Inspector: Parse InjectedScriptSource as a built-in to get guaranteed non-user-overriden built-ins
+// FIXME: <https://webkit.org/b/152294> Web Inspector: Parse InjectedScriptSource as a built-in to get guaranteed non-user-overridden built-ins
var Object = {}.constructor;
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (234562 => 234563)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2018-08-03 23:13:57 UTC (rev 234563)
@@ -1,3 +1,12 @@
+2018-08-03 Alex Christensen <[email protected]>
+
+ Fix spelling of "overridden"
+ https://bugs.webkit.org/show_bug.cgi?id=188315
+
+ Reviewed by Darin Adler.
+
+ * src/libANGLE/renderer/ProgramImpl.h:
+
2018-07-14 Kocsen Chung <[email protected]>
Ensure WebKit stack is ad-hoc signed
Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/ProgramImpl.h (234562 => 234563)
--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/ProgramImpl.h 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/ProgramImpl.h 2018-08-03 23:13:57 UTC (rev 234563)
@@ -92,7 +92,7 @@
// Implementation-specific method for ignoring unreferenced uniforms. Some implementations may
// perform more extensive analysis and ignore some locations that ANGLE doesn't detect as
- // unreferenced. This method is not required to be overriden by a back-end.
+ // unreferenced. This method is not required to be overridden by a back-end.
virtual void markUnusedUniformLocations(std::vector<gl::VariableLocation> *uniformLocations,
std::vector<gl::SamplerBinding> *samplerBindings)
{
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (234562 => 234563)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-08-03 23:13:57 UTC (rev 234563)
@@ -1,3 +1,12 @@
+2018-08-03 Alex Christensen <[email protected]>
+
+ Fix spelling of "overridden"
+ https://bugs.webkit.org/show_bug.cgi?id=188315
+
+ Reviewed by Darin Adler.
+
+ * Source/webrtc/p2p/client/basicportallocator.h:
+
2018-07-24 Thibault Saunier <[email protected]>
[WPE][GTK] Implement PeerConnection API on top of libwebrtc
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basicportallocator.h (234562 => 234563)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basicportallocator.h 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basicportallocator.h 2018-08-03 23:13:57 UTC (rev 234563)
@@ -139,7 +139,7 @@
// network (or a timeout occurs), we will start allocating ports.
virtual void ConfigReady(PortConfiguration* config);
- // MessageHandler. Can be overriden if message IDs do not conflict.
+ // MessageHandler. Can be overridden if message IDs do not conflict.
void OnMessage(rtc::Message* message) override;
private:
Modified: trunk/Source/WebCore/ChangeLog (234562 => 234563)
--- trunk/Source/WebCore/ChangeLog 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/ChangeLog 2018-08-03 23:13:57 UTC (rev 234563)
@@ -1,3 +1,34 @@
+2018-08-03 Alex Christensen <[email protected]>
+
+ Fix spelling of "overridden"
+ https://bugs.webkit.org/show_bug.cgi?id=188315
+
+ Reviewed by Darin Adler.
+
+ * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityLabel]):
+ (-[WebAccessibilityObjectWrapper accessibilityValue]):
+ * contentextensions/ContentExtensionsBackend.h:
+ * editing/EditingStyle.cpp:
+ (WebCore::EditingStyle::removeStyleFromRulesAndContext):
+ * inspector/CommandLineAPIModuleSource.js:
+ * platform/ScrollView.h:
+ * platform/ScrollableArea.h:
+ * platform/mediasession/MediaSessionInterruptionProvider.h:
+ * rendering/RenderFragmentedFlow.cpp:
+ (WebCore::RenderFragmentedFlow::adjustedPositionRelativeToOffsetParent const):
+ * rendering/RenderLayer.h:
+ * rendering/RenderListBox.h:
+ * rendering/svg/RenderSVGResourceClipper.cpp:
+ (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
+ * svg/SVGElement.cpp:
+ (WebCore::SVGElement::localCoordinateSpaceTransform const):
+ * svg/SVGLengthContext.cpp:
+ (WebCore::SVGLengthContext::SVGLengthContext):
+ (WebCore::SVGLengthContext::convertValueToUserUnits const):
+ (WebCore::SVGLengthContext::determineViewport const):
+ * svg/SVGLengthContext.h:
+
2018-08-03 Zalan Bujtas <[email protected]>
[LFC][BFC] Special case the document renderer when computing the height and margin
Modified: trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (234562 => 234563)
--- trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm 2018-08-03 23:13:57 UTC (rev 234563)
@@ -1121,7 +1121,7 @@
if (![self _prepareAccessibilityCall])
return nil;
- // check if the label was overriden
+ // check if the label was overridden
NSString *label = [super accessibilityLabel];
if (label)
return label;
@@ -1396,7 +1396,7 @@
if (![self _prepareAccessibilityCall])
return nil;
- // check if the value was overriden
+ // check if the value was overridden
NSString *value = [super accessibilityValue];
if (value)
return value;
Modified: trunk/Source/WebCore/contentextensions/ContentExtensionsBackend.h (234562 => 234563)
--- trunk/Source/WebCore/contentextensions/ContentExtensionsBackend.h 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/contentextensions/ContentExtensionsBackend.h 2018-08-03 23:13:57 UTC (rev 234563)
@@ -54,7 +54,7 @@
public:
// - Rule management interface. This can be used by upper layer.
- // Set a list of rules for a given name. If there were existing rules for the name, they are overriden.
+ // Set a list of rules for a given name. If there were existing rules for the name, they are overridden.
// The identifier cannot be empty.
WEBCORE_EXPORT void addContentExtension(const String& identifier, Ref<CompiledContentExtension>, ContentExtension::ShouldCompileCSS = ContentExtension::ShouldCompileCSS::Yes);
WEBCORE_EXPORT void removeContentExtension(const String& identifier);
Modified: trunk/Source/WebCore/editing/EditingStyle.cpp (234562 => 234563)
--- trunk/Source/WebCore/editing/EditingStyle.cpp 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/editing/EditingStyle.cpp 2018-08-03 23:13:57 UTC (rev 234563)
@@ -1318,7 +1318,7 @@
if (styleFromMatchedRules && !styleFromMatchedRules->isEmpty())
m_mutableStyle = getPropertiesNotIn(*m_mutableStyle, *styleFromMatchedRules);
- // 2. Remove style present in context and not overriden by matched rules.
+ // 2. Remove style present in context and not overridden by matched rules.
RefPtr<EditingStyle> computedStyle = EditingStyle::create(context, EditingPropertiesInEffect);
if (computedStyle->m_mutableStyle) {
if (!computedStyle->m_mutableStyle->getPropertyCSSValue(CSSPropertyBackgroundColor))
@@ -1328,7 +1328,7 @@
m_mutableStyle = getPropertiesNotIn(*m_mutableStyle, *computedStyle->m_mutableStyle);
}
- // 3. If this element is a span and has display: inline or float: none, remove them unless they are overriden by rules.
+ // 3. If this element is a span and has display: inline or float: none, remove them unless they are overridden by rules.
// These rules are added by serialization code to wrap text nodes.
if (isStyleSpanOrSpanWithOnlyStyleAttribute(element)) {
if (!styleFromMatchedRules->getPropertyCSSValue(CSSPropertyDisplay) && identifierForStyleProperty(*m_mutableStyle, CSSPropertyDisplay) == CSSValueInline)
Modified: trunk/Source/WebCore/inspector/CommandLineAPIModuleSource.js (234562 => 234563)
--- trunk/Source/WebCore/inspector/CommandLineAPIModuleSource.js 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/inspector/CommandLineAPIModuleSource.js 2018-08-03 23:13:57 UTC (rev 234563)
@@ -30,7 +30,7 @@
(function (InjectedScriptHost, inspectedWindow, injectedScriptId, injectedScript, RemoteObject, CommandLineAPIHost) {
-// FIXME: <https://webkit.org/b/152294> Web Inspector: Parse InjectedScriptSource as a built-in to get guaranteed non-user-overriden built-ins
+// FIXME: <https://webkit.org/b/152294> Web Inspector: Parse InjectedScriptSource as a built-in to get guaranteed non-user-overridden built-ins
function bind(func, thisObject, ...outerArgs)
{
Modified: trunk/Source/WebCore/platform/ScrollView.h (234562 => 234563)
--- trunk/Source/WebCore/platform/ScrollView.h 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/platform/ScrollView.h 2018-08-03 23:13:57 UTC (rev 234563)
@@ -78,7 +78,7 @@
IntPoint locationOfContents() const;
- // NOTE: This should only be called by the overriden setScrollOffset from ScrollableArea.
+ // NOTE: This should only be called by the overridden setScrollOffset from ScrollableArea.
virtual void scrollTo(const ScrollPosition&);
// The window thats hosts the ScrollView. The ScrollView will communicate scrolls and repaints to the
Modified: trunk/Source/WebCore/platform/ScrollableArea.h (234562 => 234563)
--- trunk/Source/WebCore/platform/ScrollableArea.h 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/platform/ScrollableArea.h 2018-08-03 23:13:57 UTC (rev 234563)
@@ -344,7 +344,7 @@
friend class ScrollAnimator;
void setScrollOffsetFromAnimation(const ScrollOffset&);
- // This function should be overriden by subclasses to perform the actual
+ // This function should be overridden by subclasses to perform the actual
// scroll of the content.
virtual void setScrollOffset(const ScrollOffset&) = 0;
ScrollSnapOffsetsInfo<LayoutUnit>& ensureSnapOffsetsInfo();
Modified: trunk/Source/WebCore/platform/mediasession/MediaSessionInterruptionProvider.h (234562 => 234563)
--- trunk/Source/WebCore/platform/mediasession/MediaSessionInterruptionProvider.h 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/platform/mediasession/MediaSessionInterruptionProvider.h 2018-08-03 23:13:57 UTC (rev 234563)
@@ -52,7 +52,7 @@
explicit MediaSessionInterruptionProvider(MediaSessionInterruptionProviderClient&);
virtual ~MediaSessionInterruptionProvider();
- // To be overriden by subclasses.
+ // To be overridden by subclasses.
virtual void beginListeningForInterruptions() = 0;
virtual void stopListeningForInterruptions() = 0;
Modified: trunk/Source/WebCore/rendering/RenderFragmentedFlow.cpp (234562 => 234563)
--- trunk/Source/WebCore/rendering/RenderFragmentedFlow.cpp 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/rendering/RenderFragmentedFlow.cpp 2018-08-03 23:13:57 UTC (rev 234563)
@@ -311,7 +311,7 @@
LayoutUnit topRelativeToFragment = top - fragmentLogicalTop;
referencePoint.setY(startFragmentBox->offsetTop() + topRelativeToFragment);
- // Since the top has been overriden, check if the
+ // Since the top has been overridden, check if the
// relative/sticky positioning must be reconsidered.
if (boxModelObject.isRelativelyPositioned())
referencePoint.move(0, boxModelObject.relativePositionOffset().height());
Modified: trunk/Source/WebCore/rendering/RenderLayer.h (234562 => 234563)
--- trunk/Source/WebCore/rendering/RenderLayer.h 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/rendering/RenderLayer.h 2018-08-03 23:13:57 UTC (rev 234563)
@@ -930,7 +930,7 @@
// Rectangle encompassing the scroll corner and resizer rect.
LayoutRect scrollCornerAndResizerRect() const;
- // NOTE: This should only be called by the overriden setScrollOffset from ScrollableArea.
+ // NOTE: This should only be called by the overridden setScrollOffset from ScrollableArea.
void scrollTo(const ScrollPosition&);
void updateCompositingLayersAfterScroll();
Modified: trunk/Source/WebCore/rendering/RenderListBox.h (234562 => 234563)
--- trunk/Source/WebCore/rendering/RenderListBox.h 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/rendering/RenderListBox.h 2018-08-03 23:13:57 UTC (rev 234563)
@@ -141,7 +141,7 @@
bool usesMockScrollAnimator() const override;
void logMockScrollAnimatorMessage(const String&) const override;
- // NOTE: This should only be called by the overriden setScrollOffset from ScrollableArea.
+ // NOTE: This should only be called by the overridden setScrollOffset from ScrollableArea.
void scrollTo(int newOffset);
using PaintFunction = WTF::Function<void(PaintInfo&, const LayoutPoint&, int listItemIndex)>;
Modified: trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp (234562 => 234563)
--- trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/rendering/svg/RenderSVGResourceClipper.cpp 2018-08-03 23:13:57 UTC (rev 234563)
@@ -228,7 +228,7 @@
// In the case of a <use> element, we obtained its renderere above, to retrieve its clipRule.
// We have to pass the <use> renderer itself to renderSubtreeToImageBuffer() to apply it's x/y/transform/etc. values when rendering.
- // So if isUseElement is true, refetch the childNode->renderer(), as renderer got overriden above.
+ // So if isUseElement is true, refetch the childNode->renderer(), as renderer got overridden above.
SVGRenderingContext::renderSubtreeToImageBuffer(clipperMaskImage.get(), isUseElement ? *child.renderer() : *renderer, maskContentTransformation);
}
Modified: trunk/Source/WebCore/svg/SVGElement.cpp (234562 => 234563)
--- trunk/Source/WebCore/svg/SVGElement.cpp 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/svg/SVGElement.cpp 2018-08-03 23:13:57 UTC (rev 234563)
@@ -1063,7 +1063,7 @@
AffineTransform SVGElement::localCoordinateSpaceTransform(SVGLocatable::CTMScope) const
{
- // To be overriden by SVGGraphicsElement (or as special case SVGTextElement and SVGPatternElement)
+ // To be overridden by SVGGraphicsElement (or as special case SVGTextElement and SVGPatternElement)
return AffineTransform();
}
Modified: trunk/Source/WebCore/svg/SVGLengthContext.cpp (234562 => 234563)
--- trunk/Source/WebCore/svg/SVGLengthContext.cpp 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/svg/SVGLengthContext.cpp 2018-08-03 23:13:57 UTC (rev 234563)
@@ -42,7 +42,7 @@
SVGLengthContext::SVGLengthContext(const SVGElement* context, const FloatRect& viewport)
: m_context(context)
- , m_overridenViewport(viewport)
+ , m_overriddenViewport(viewport)
{
}
@@ -113,7 +113,7 @@
ExceptionOr<float> SVGLengthContext::convertValueToUserUnits(float value, SVGLengthMode mode, SVGLengthType fromUnit) const
{
// If the SVGLengthContext carries a custom viewport, force resolving against it.
- if (!m_overridenViewport.isEmpty()) {
+ if (!m_overriddenViewport.isEmpty()) {
// 100% = 100.0 instead of 1.0 for historical reasons, this could eventually be changed
if (fromUnit == LengthTypePercentage)
value /= 100;
@@ -288,9 +288,9 @@
if (!m_context)
return false;
- // If an overriden viewport is given, it has precedence.
- if (!m_overridenViewport.isEmpty()) {
- viewportSize = m_overridenViewport.size();
+ // If an overridden viewport is given, it has precedence.
+ if (!m_overriddenViewport.isEmpty()) {
+ viewportSize = m_overriddenViewport.size();
return true;
}
Modified: trunk/Source/WebCore/svg/SVGLengthContext.h (234562 => 234563)
--- trunk/Source/WebCore/svg/SVGLengthContext.h 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebCore/svg/SVGLengthContext.h 2018-08-03 23:13:57 UTC (rev 234563)
@@ -83,7 +83,7 @@
ExceptionOr<float> convertValueFromEXSToUserUnits(float value) const;
const SVGElement* m_context;
- FloatRect m_overridenViewport;
+ FloatRect m_overriddenViewport;
};
} // namespace WebCore
Modified: trunk/Source/WebInspectorUI/ChangeLog (234562 => 234563)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-08-03 23:13:57 UTC (rev 234563)
@@ -1,3 +1,23 @@
+2018-08-03 Alex Christensen <[email protected]>
+
+ Fix spelling of "overridden"
+ https://bugs.webkit.org/show_bug.cgi?id=188315
+
+ Reviewed by Darin Adler.
+
+ * UserInterface/Views/ContentBrowserTabContentView.js:
+ (WI.ContentBrowserTabContentView.prototype.treeElementForRepresentedObject):
+ * UserInterface/Views/GeneralTreeElement.js:
+ (WI.GeneralTreeElement.prototype.ondetach):
+ * UserInterface/Views/NavigationBar.js:
+ (WI.NavigationBar.prototype.get sizesToFit):
+ * UserInterface/Views/NavigationSidebarPanel.js:
+ (WI.NavigationSidebarPanel.prototype.shouldFilterPopulate):
+ * UserInterface/Views/TextEditor.js:
+ (WI.TextEditor.prototype.canBeFormatted):
+ * UserInterface/Views/TreeElement.js:
+ (WI.TreeElement.prototype.onpopulate):
+
2018-08-01 Nikita Vasilyev <[email protected]>
Web Inspector: Dark Mode: SourceCodeTextEditor thread indicator widget is too light
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js (234562 => 234563)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentBrowserTabContentView.js 2018-08-03 23:13:57 UTC (rev 234563)
@@ -242,7 +242,7 @@
treeElementForRepresentedObject(representedObject)
{
- // Can be overriden by subclasses.
+ // Can be overridden by subclasses.
if (!this.navigationSidebarPanel)
return null;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js (234562 => 234563)
--- trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/GeneralTreeElement.js 2018-08-03 23:13:57 UTC (rev 234563)
@@ -212,7 +212,7 @@
ondetach()
{
- // Overriden by subclasses.
+ // Overridden by subclasses.
}
onreveal()
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js (234562 => 234563)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationBar.js 2018-08-03 23:13:57 UTC (rev 234563)
@@ -171,7 +171,7 @@
get sizesToFit()
{
- // Can be overriden by subclasses.
+ // Can be overridden by subclasses.
return false;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js (234562 => 234563)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NavigationSidebarPanel.js 2018-08-03 23:13:57 UTC (rev 234563)
@@ -308,7 +308,7 @@
shouldFilterPopulate()
{
- // Overriden by subclasses if needed.
+ // Overridden by subclasses if needed.
return this.hasCustomFilters();
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js (234562 => 234563)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2018-08-03 23:13:57 UTC (rev 234563)
@@ -196,7 +196,7 @@
canBeFormatted()
{
- // Can be overriden by subclasses.
+ // Can be overridden by subclasses.
return this.hasFormatter();
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js (234562 => 234563)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js 2018-08-03 23:13:57 UTC (rev 234563)
@@ -586,7 +586,7 @@
onpopulate()
{
- // Overriden by subclasses.
+ // Overridden by subclasses.
}
traverseNextTreeElement(skipUnrevealed, stayWithin, dontPopulate, info)
Modified: trunk/Source/WebKit/ChangeLog (234562 => 234563)
--- trunk/Source/WebKit/ChangeLog 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebKit/ChangeLog 2018-08-03 23:13:57 UTC (rev 234563)
@@ -1,3 +1,36 @@
+2018-08-03 Alex Christensen <[email protected]>
+
+ Fix spelling of "overridden"
+ https://bugs.webkit.org/show_bug.cgi?id=188315
+
+ Reviewed by Darin Adler.
+
+ * Platform/IPC/mac/ConnectionMac.mm:
+ (IPC::Connection::receiveSourceEventHandler):
+ * Shared/WebPreferencesStore.cpp:
+ (WebKit::WebPreferencesStore::encode const):
+ (WebKit::WebPreferencesStore::decode):
+ (WebKit::valueForKey):
+ (WebKit::setValueForKey):
+ (WebKit::WebPreferencesStore::setStringValueForKey):
+ (WebKit::WebPreferencesStore::getStringValueForKey const):
+ (WebKit::WebPreferencesStore::setBoolValueForKey):
+ (WebKit::WebPreferencesStore::getBoolValueForKey const):
+ (WebKit::WebPreferencesStore::setUInt32ValueForKey):
+ (WebKit::WebPreferencesStore::getUInt32ValueForKey const):
+ (WebKit::WebPreferencesStore::setDoubleValueForKey):
+ (WebKit::WebPreferencesStore::getDoubleValueForKey const):
+ (WebKit::WebPreferencesStore::setOverrideDefaultsStringValueForKey):
+ (WebKit::WebPreferencesStore::setOverrideDefaultsBoolValueForKey):
+ (WebKit::WebPreferencesStore::setOverrideDefaultsUInt32ValueForKey):
+ (WebKit::WebPreferencesStore::setOverrideDefaultsDoubleValueForKey):
+ * Shared/WebPreferencesStore.h:
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView dragInteraction:previewForLiftingItem:session:]):
+ (-[WKContentView dragInteraction:previewForCancellingItem:withDefault:]):
+ * UIProcess/ios/WKScrollView.mm:
+ (-[WKScrollView _systemContentInset]):
+
2018-08-03 David Fenton <[email protected]>
Unreviewed, rolling out r234517.
Modified: trunk/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm (234562 => 234563)
--- trunk/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebKit/Platform/IPC/mac/ConnectionMac.mm 2018-08-03 23:13:57 UTC (rev 234563)
@@ -582,7 +582,7 @@
#if !PLATFORM(IOS)
if (decoder->messageReceiverName() == "IPC" && decoder->messageName() == "SetExceptionPort") {
if (m_isServer) {
- // Server connections aren't supposed to have their exception ports overriden. Treat this as an invalid message.
+ // Server connections aren't supposed to have their exception ports overridden. Treat this as an invalid message.
StringReference messageReceiverNameReference = decoder->messageReceiverName();
String messageReceiverName(String(messageReceiverNameReference.data(), messageReceiverNameReference.size()));
StringReference messageNameReference = decoder->messageName();
Modified: trunk/Source/WebKit/Shared/WebPreferencesStore.cpp (234562 => 234563)
--- trunk/Source/WebKit/Shared/WebPreferencesStore.cpp 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebKit/Shared/WebPreferencesStore.cpp 2018-08-03 23:13:57 UTC (rev 234563)
@@ -49,7 +49,7 @@
void WebPreferencesStore::encode(IPC::Encoder& encoder) const
{
encoder << m_values;
- encoder << m_overridenDefaults;
+ encoder << m_overriddenDefaults;
}
bool WebPreferencesStore::decode(IPC::Decoder& decoder, WebPreferencesStore& result)
@@ -60,11 +60,11 @@
return false;
result.m_values = WTFMove(*values);
- std::optional<HashMap<String, Value>> overridenDefaults;
- decoder >> overridenDefaults;
- if (!overridenDefaults)
+ std::optional<HashMap<String, Value>> overriddenDefaults;
+ decoder >> overriddenDefaults;
+ if (!overriddenDefaults)
return false;
- result.m_overridenDefaults = WTFMove(*overridenDefaults);
+ result.m_overriddenDefaults = WTFMove(*overriddenDefaults);
return true;
}
@@ -79,15 +79,15 @@
}
template<typename MappedType>
-static MappedType valueForKey(const WebPreferencesStore::ValueMap& values, const WebPreferencesStore::ValueMap& overridenDefaults, const String& key)
+static MappedType valueForKey(const WebPreferencesStore::ValueMap& values, const WebPreferencesStore::ValueMap& overriddenDefaults, const String& key)
{
auto valuesIt = values.find(key);
if (valuesIt != values.end() && WTF::holds_alternative<MappedType>(valuesIt->value))
return WTF::get<MappedType>(valuesIt->value);
- auto overridenDefaultsIt = overridenDefaults.find(key);
- if (overridenDefaultsIt != overridenDefaults.end() && WTF::holds_alternative<MappedType>(overridenDefaultsIt->value))
- return WTF::get<MappedType>(overridenDefaultsIt->value);
+ auto overriddenDefaultsIt = overriddenDefaults.find(key);
+ if (overriddenDefaultsIt != overriddenDefaults.end() && WTF::holds_alternative<MappedType>(overriddenDefaultsIt->value))
+ return WTF::get<MappedType>(overriddenDefaultsIt->value);
auto& defaultsMap = WebPreferencesStore::defaults();
auto defaultsIt = defaultsMap.find(key);
@@ -98,9 +98,9 @@
}
template<typename MappedType>
-static bool setValueForKey(WebPreferencesStore::ValueMap& map, const WebPreferencesStore::ValueMap& overridenDefaults, const String& key, const MappedType& value)
+static bool setValueForKey(WebPreferencesStore::ValueMap& map, const WebPreferencesStore::ValueMap& overriddenDefaults, const String& key, const MappedType& value)
{
- MappedType existingValue = valueForKey<MappedType>(map, overridenDefaults, key);
+ MappedType existingValue = valueForKey<MappedType>(map, overriddenDefaults, key);
if (existingValue == value)
return false;
@@ -110,17 +110,17 @@
bool WebPreferencesStore::setStringValueForKey(const String& key, const String& value)
{
- return setValueForKey<String>(m_values, m_overridenDefaults, key, value);
+ return setValueForKey<String>(m_values, m_overriddenDefaults, key, value);
}
String WebPreferencesStore::getStringValueForKey(const String& key) const
{
- return valueForKey<String>(m_values, m_overridenDefaults, key);
+ return valueForKey<String>(m_values, m_overriddenDefaults, key);
}
bool WebPreferencesStore::setBoolValueForKey(const String& key, bool value)
{
- return setValueForKey<bool>(m_values, m_overridenDefaults, key, value);
+ return setValueForKey<bool>(m_values, m_overriddenDefaults, key, value);
}
bool WebPreferencesStore::getBoolValueForKey(const String& key) const
@@ -130,49 +130,49 @@
if (it != boolTestRunnerOverridesMap().end())
return it->value;
- return valueForKey<bool>(m_values, m_overridenDefaults, key);
+ return valueForKey<bool>(m_values, m_overriddenDefaults, key);
}
bool WebPreferencesStore::setUInt32ValueForKey(const String& key, uint32_t value)
{
- return setValueForKey<uint32_t>(m_values, m_overridenDefaults, key, value);
+ return setValueForKey<uint32_t>(m_values, m_overriddenDefaults, key, value);
}
uint32_t WebPreferencesStore::getUInt32ValueForKey(const String& key) const
{
- return valueForKey<uint32_t>(m_values, m_overridenDefaults, key);
+ return valueForKey<uint32_t>(m_values, m_overriddenDefaults, key);
}
bool WebPreferencesStore::setDoubleValueForKey(const String& key, double value)
{
- return setValueForKey<double>(m_values, m_overridenDefaults, key, value);
+ return setValueForKey<double>(m_values, m_overriddenDefaults, key, value);
}
double WebPreferencesStore::getDoubleValueForKey(const String& key) const
{
- return valueForKey<double>(m_values, m_overridenDefaults, key);
+ return valueForKey<double>(m_values, m_overriddenDefaults, key);
}
-// Overriden Defaults
+// Overridden Defaults
void WebPreferencesStore::setOverrideDefaultsStringValueForKey(const String& key, String value)
{
- m_overridenDefaults.set(key, Value(value));
+ m_overriddenDefaults.set(key, Value(value));
}
void WebPreferencesStore::setOverrideDefaultsBoolValueForKey(const String& key, bool value)
{
- m_overridenDefaults.set(key, Value(value));
+ m_overriddenDefaults.set(key, Value(value));
}
void WebPreferencesStore::setOverrideDefaultsUInt32ValueForKey(const String& key, uint32_t value)
{
- m_overridenDefaults.set(key, Value(value));
+ m_overriddenDefaults.set(key, Value(value));
}
void WebPreferencesStore::setOverrideDefaultsDoubleValueForKey(const String& key, double value)
{
- m_overridenDefaults.set(key, Value(value));
+ m_overriddenDefaults.set(key, Value(value));
}
} // namespace WebKit
Modified: trunk/Source/WebKit/Shared/WebPreferencesStore.h (234562 => 234563)
--- trunk/Source/WebKit/Shared/WebPreferencesStore.h 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebKit/Shared/WebPreferencesStore.h 2018-08-03 23:13:57 UTC (rev 234563)
@@ -66,7 +66,7 @@
typedef HashMap<String, Value> ValueMap;
ValueMap m_values;
- ValueMap m_overridenDefaults;
+ ValueMap m_overriddenDefaults;
static ValueMap& defaults();
};
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (234562 => 234563)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2018-08-03 23:13:57 UTC (rev 234563)
@@ -5257,9 +5257,9 @@
{
id <WKUIDelegatePrivate> uiDelegate = self.webViewUIDelegate;
if ([uiDelegate respondsToSelector:@selector(_webView:previewForLiftingItem:session:)]) {
- UITargetedDragPreview *overridenPreview = [uiDelegate _webView:_webView previewForLiftingItem:item session:session];
- if (overridenPreview)
- return overridenPreview;
+ UITargetedDragPreview *overriddenPreview = [uiDelegate _webView:_webView previewForLiftingItem:item session:session];
+ if (overriddenPreview)
+ return overriddenPreview;
}
return _dragDropInteractionState.previewForDragItem(item, self, self.unscaledView);
}
@@ -5321,9 +5321,9 @@
{
id <WKUIDelegatePrivate> uiDelegate = self.webViewUIDelegate;
if ([uiDelegate respondsToSelector:@selector(_webView:previewForCancellingItem:withDefault:)]) {
- UITargetedDragPreview *overridenPreview = [uiDelegate _webView:_webView previewForCancellingItem:item withDefault:defaultPreview];
- if (overridenPreview)
- return overridenPreview;
+ UITargetedDragPreview *overriddenPreview = [uiDelegate _webView:_webView previewForCancellingItem:item withDefault:defaultPreview];
+ if (overriddenPreview)
+ return overriddenPreview;
}
return _dragDropInteractionState.previewForDragItem(item, self, self.unscaledView);
}
Modified: trunk/Source/WebKit/UIProcess/ios/WKScrollView.mm (234562 => 234563)
--- trunk/Source/WebKit/UIProcess/ios/WKScrollView.mm 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebKit/UIProcess/ios/WKScrollView.mm 2018-08-03 23:13:57 UTC (rev 234563)
@@ -342,7 +342,7 @@
UIEdgeInsets systemContentInset = [super _systemContentInset];
// Internal clients who use setObscuredInsets include the keyboard height in their
- // manually overriden insets, so we don't need to re-add it here.
+ // manually overridden insets, so we don't need to re-add it here.
if (_internalDelegate._haveSetObscuredInsets)
return systemContentInset;
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (234562 => 234563)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-08-03 23:13:57 UTC (rev 234563)
@@ -1,3 +1,18 @@
+2018-08-03 Alex Christensen <[email protected]>
+
+ Fix spelling of "overridden"
+ https://bugs.webkit.org/show_bug.cgi?id=188315
+
+ Reviewed by Darin Adler.
+
+ * Misc/WebKitVersionChecks.mm:
+ (setWebKitLinkTimeVersion):
+ (WebKitLinkTimeVersion):
+ * Plugins/WebBaseNetscapePluginView.mm:
+ (-[WebBaseNetscapePluginView handleMouseMoved:]):
+ * WebCoreSupport/PopupMenuMac.mm:
+ (PopupMenuMac::populate):
+
2018-08-01 Nan Wang <[email protected]>
AX: AOM: Add ARIA IDL Attribute Reflection
Modified: trunk/Source/WebKitLegacy/mac/Misc/WebKitVersionChecks.mm (234562 => 234563)
--- trunk/Source/WebKitLegacy/mac/Misc/WebKitVersionChecks.mm 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebKitLegacy/mac/Misc/WebKitVersionChecks.mm 2018-08-03 23:13:57 UTC (rev 234563)
@@ -31,7 +31,7 @@
#import <mach-o/dyld.h>
static int WebKitLinkTimeVersion(void);
-static int overridenWebKitLinkTimeVersion;
+static int overriddenWebKitLinkTimeVersion;
BOOL WebKitLinkedOnOrAfter(int version)
{
@@ -51,13 +51,13 @@
void setWebKitLinkTimeVersion(int version)
{
- overridenWebKitLinkTimeVersion = version;
+ overriddenWebKitLinkTimeVersion = version;
}
static int WebKitLinkTimeVersion(void)
{
- if (overridenWebKitLinkTimeVersion)
- return overridenWebKitLinkTimeVersion;
+ if (overriddenWebKitLinkTimeVersion)
+ return overriddenWebKitLinkTimeVersion;
#if !PLATFORM(IOS)
return NSVersionOfLinkTimeLibrary("WebKit");
Modified: trunk/Source/WebKitLegacy/mac/Plugins/WebBaseNetscapePluginView.mm (234562 => 234563)
--- trunk/Source/WebKitLegacy/mac/Plugins/WebBaseNetscapePluginView.mm 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebKitLegacy/mac/Plugins/WebBaseNetscapePluginView.mm 2018-08-03 23:13:57 UTC (rev 234563)
@@ -165,7 +165,7 @@
- (void)handleMouseMoved:(NSEvent *)event
{
- // This needs to be overriden by subclasses.
+ // This needs to be overridden by subclasses.
}
- (void)handleMouseEntered:(NSEvent *)event
Modified: trunk/Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm (234562 => 234563)
--- trunk/Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm 2018-08-03 23:10:26 UTC (rev 234562)
+++ trunk/Source/WebKitLegacy/mac/WebCoreSupport/PopupMenuMac.mm 2018-08-03 23:13:57 UTC (rev 234563)
@@ -115,7 +115,7 @@
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
- // Allow the accessible text of the item to be overriden if necessary.
+ // Allow the accessible text of the item to be overridden if necessary.
if (AXObjectCache::accessibilityEnabled()) {
NSString *accessibilityOverride = m_client->itemAccessibilityText(i);
if ([accessibilityOverride length])
