Title: [234580] trunk/Source/_javascript_Core
- Revision
- 234580
- Author
- [email protected]
- Date
- 2018-08-04 13:07:13 -0700 (Sat, 04 Aug 2018)
Log Message
REGRESSION (r208953): TemplateObjectDescriptor constructor calculates m_hash on use-after-move variable
<https://webkit.org/b/188331>
Reviewed by Yusuke Suzuki.
* runtime/TemplateObjectDescriptor.h:
(JSC::TemplateObjectDescriptor::TemplateObjectDescriptor):
Use `m_rawstrings` instead of `rawStrings` to calculate hash.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (234579 => 234580)
--- trunk/Source/_javascript_Core/ChangeLog 2018-08-04 17:38:13 UTC (rev 234579)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-08-04 20:07:13 UTC (rev 234580)
@@ -1,3 +1,14 @@
+2018-08-04 David Kilzer <[email protected]>
+
+ REGRESSION (r208953): TemplateObjectDescriptor constructor calculates m_hash on use-after-move variable
+ <https://webkit.org/b/188331>
+
+ Reviewed by Yusuke Suzuki.
+
+ * runtime/TemplateObjectDescriptor.h:
+ (JSC::TemplateObjectDescriptor::TemplateObjectDescriptor):
+ Use `m_rawstrings` instead of `rawStrings` to calculate hash.
+
2018-08-03 Saam Barati <[email protected]>
Give the `jsc` shell the JIT entitlement
Modified: trunk/Source/_javascript_Core/runtime/TemplateObjectDescriptor.h (234579 => 234580)
--- trunk/Source/_javascript_Core/runtime/TemplateObjectDescriptor.h 2018-08-04 17:38:13 UTC (rev 234579)
+++ trunk/Source/_javascript_Core/runtime/TemplateObjectDescriptor.h 2018-08-04 20:07:13 UTC (rev 234580)
@@ -81,7 +81,7 @@
inline TemplateObjectDescriptor::TemplateObjectDescriptor(StringVector&& rawStrings, OptionalStringVector&& cookedStrings)
: m_rawStrings(WTFMove(rawStrings))
, m_cookedStrings(WTFMove(cookedStrings))
- , m_hash(calculateHash(rawStrings))
+ , m_hash(calculateHash(m_rawStrings))
{
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes