Title: [234583] trunk/Source/WebCore
- Revision
- 234583
- Author
- ms2...@igalia.com
- Date
- 2018-08-05 03:10:10 -0700 (Sun, 05 Aug 2018)
Log Message
[GStreamer] Remove unsound assertions in MediaPlayerPrivateGStreamerBase.
https://bugs.webkit.org/show_bug.cgi?id=188162
Reviewed by Philippe Normand.
These assertions sometimes fail, and there's a runtime check right
after them anyway.
Tests: fast/canvas/webgl/texImage2D-video-flipY-false.html
fast/canvas/webgl/texImage2D-video-flipY-true.html
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::copyVideoTextureToPlatformTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (234582 => 234583)
--- trunk/Source/WebCore/ChangeLog 2018-08-05 09:26:00 UTC (rev 234582)
+++ trunk/Source/WebCore/ChangeLog 2018-08-05 10:10:10 UTC (rev 234583)
@@ -1,3 +1,20 @@
+2018-08-05 Ms2ger <ms2...@igalia.com>
+
+ [GStreamer] Remove unsound assertions in MediaPlayerPrivateGStreamerBase.
+ https://bugs.webkit.org/show_bug.cgi?id=188162
+
+ Reviewed by Philippe Normand.
+
+ These assertions sometimes fail, and there's a runtime check right
+ after them anyway.
+
+ Tests: fast/canvas/webgl/texImage2D-video-flipY-false.html
+ fast/canvas/webgl/texImage2D-video-flipY-true.html
+
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
+ (WebCore::MediaPlayerPrivateGStreamerBase::copyVideoTextureToPlatformTexture):
+ (WebCore::MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime):
+
2018-08-05 Philippe Normand <pnorm...@igalia.com>
[MediaCapabilities] Platform integration
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp (234582 => 234583)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2018-08-05 09:26:00 UTC (rev 234582)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp 2018-08-05 10:10:10 UTC (rev 234583)
@@ -938,7 +938,6 @@
std::unique_ptr<GstVideoFrameHolder> frameHolder = std::make_unique<GstVideoFrameHolder>(m_sample.get(), texMapFlagFromOrientation(m_videoSourceOrientation), true);
auto textureID = frameHolder->textureID();
- ASSERT(textureID);
if (!textureID)
return false;
@@ -966,7 +965,6 @@
std::unique_ptr<GstVideoFrameHolder> frameHolder = std::make_unique<GstVideoFrameHolder>(m_sample.get(), texMapFlagFromOrientation(m_videoSourceOrientation), true);
auto textureID = frameHolder->textureID();
- ASSERT(textureID);
if (!textureID)
return nullptr;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
