Title: [234591] trunk/LayoutTests
Revision
234591
Author
commit-qu...@webkit.org
Date
2018-08-06 01:25:29 -0700 (Mon, 06 Aug 2018)

Log Message

ASSERTION !data.customElementReactionQueue() when creating custom element inside an SVG document
https://bugs.webkit.org/show_bug.cgi?id=187802

The assertion has been removed in bug 188327. This patch updates the test expectations and
add some non-regression test to verify different cases of XML custom element construction.

Patch by Frederic Wang <fw...@igalia.com> on 2018-08-06
Reviewed by Ryosuke Niwa.

* TestExpectations: This test no longer crashes but times out because of bug 187800.
* fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt: Added.
* fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (234590 => 234591)


--- trunk/LayoutTests/ChangeLog	2018-08-06 08:14:21 UTC (rev 234590)
+++ trunk/LayoutTests/ChangeLog	2018-08-06 08:25:29 UTC (rev 234591)
@@ -1,3 +1,17 @@
+2018-08-06  Frederic Wang  <fw...@igalia.com>
+
+        ASSERTION !data.customElementReactionQueue() when creating custom element inside an SVG document
+        https://bugs.webkit.org/show_bug.cgi?id=187802
+
+        The assertion has been removed in bug 188327. This patch updates the test expectations and
+        add some non-regression test to verify different cases of XML custom element construction.
+
+        Reviewed by Ryosuke Niwa.
+
+        * TestExpectations: This test no longer crashes but times out because of bug 187800.
+        * fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt: Added.
+        * fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg: Added.
+
 2018-08-05  Yusuke Suzuki  <utatane....@gmail.com>
 
         Implement self.queueMicrotask in Workers

Modified: trunk/LayoutTests/TestExpectations (234590 => 234591)


--- trunk/LayoutTests/TestExpectations	2018-08-06 08:14:21 UTC (rev 234590)
+++ trunk/LayoutTests/TestExpectations	2018-08-06 08:25:29 UTC (rev 234591)
@@ -570,7 +570,7 @@
 
 # WPT tests for custom elements
 webkit.org/b/187800 imported/w3c/web-platform-tests/custom-elements/Document-createElement-svg.svg [ Skip ]
-webkit.org/b/187802 imported/w3c/web-platform-tests/custom-elements/parser/parser-uses-create-an-element-for-a-token-svg.svg [ Skip ]
+webkit.org/b/187800 imported/w3c/web-platform-tests/custom-elements/parser/parser-uses-create-an-element-for-a-token-svg.svg [ Skip ]
 
 # selectors
 webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors/selectors-dir-selector-ltr-001.html [ ImageOnlyFailure ]

Added: trunk/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt (0 => 234591)


--- trunk/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token-expected.txt	2018-08-06 08:25:29 UTC (rev 234591)
@@ -0,0 +1 @@
+This test passes if it does not crash.

Added: trunk/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg (0 => 234591)


--- trunk/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg	                        (rev 0)
+++ trunk/LayoutTests/fast/custom-elements/xml-parsing-create-and-element-for-a-token.svg	2018-08-06 08:25:29 UTC (rev 234591)
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<svg:svg xmlns:svg="http://www.w3.org/2000/svg"
+         xmlns="http://www.w3.org/1999/xhtml">
+<svg:text>This test passes if it does not crash.</svg:text>
+<script><![CDATA[
+if (testRunner)
+    testRunner.dumpAsText();
+class MyElement extends HTMLElement {}
+customElements.define('my-element', MyElement);
+]]></script>
+<my-element></my-element>
+<element-without-definition></element-without-definition>
+<script><![CDATA[
+document.documentElement.insertAdjacentHTML("beforeend", "<my-element></my-element>");
+]]></script>
+</svg:svg>
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to