[webkit-changes] [234679] trunk/Source/WebCore

[commit-queue]

Title: [234679] trunk/Source/WebCore

Revision

234679

Author

commit-qu...@webkit.org

Date

2018-08-07 16:46:22 -0700 (Tue, 07 Aug 2018)

Log Message

Use 1-byte enum class for Document::StandaloneStatus
https://bugs.webkit.org/show_bug.cgi?id=188352

Patch by Alex Christensen <achristen...@webkit.org> on 2018-08-07
Reviewed by Chris Dumez.

* dom/Document.cpp:
(WebCore::Document::setXMLStandalone):
* dom/Document.h:
(WebCore::Document::xmlStandalone const):
* editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendXMLDeclaration):

Modified Paths

• trunk/Source/WebCore/ChangeLog
• trunk/Source/WebCore/dom/Document.cpp
• trunk/Source/WebCore/dom/Document.h
• trunk/Source/WebCore/editing/MarkupAccumulator.cpp

Diff

Modified: trunk/Source/WebCore/ChangeLog (234678 => 234679)

--- trunk/Source/WebCore/ChangeLog	2018-08-07 23:26:48 UTC (rev 234678)
+++ trunk/Source/WebCore/ChangeLog	2018-08-07 23:46:22 UTC (rev 234679)
@@ -1,3 +1,17 @@
+2018-08-07  Alex Christensen  <achristen...@webkit.org>
+
+        Use 1-byte enum class for Document::StandaloneStatus
+        https://bugs.webkit.org/show_bug.cgi?id=188352
+
+        Reviewed by Chris Dumez.
+
+        * dom/Document.cpp:
+        (WebCore::Document::setXMLStandalone):
+        * dom/Document.h:
+        (WebCore::Document::xmlStandalone const):
+        * editing/MarkupAccumulator.cpp:
+        (WebCore::MarkupAccumulator::appendXMLDeclaration):
+
 2018-08-07  Rob Buis  <rb...@igalia.com>
 
         fetch() with subresource integrity crashes on zero length body

Modified: trunk/Source/WebCore/dom/Document.cpp (234678 => 234679)

--- trunk/Source/WebCore/dom/Document.cpp	2018-08-07 23:26:48 UTC (rev 234678)
+++ trunk/Source/WebCore/dom/Document.cpp	2018-08-07 23:46:22 UTC (rev 234679)
@@ -1350,7 +1350,7 @@
 
 void Document::setXMLStandalone(bool standalone)
 {
-    m_xmlStandalone = standalone ? Standalone : NotStandalone;
+    m_xmlStandalone = standalone ? StandaloneStatus::Standalone : StandaloneStatus::NotStandalone;
 }
 
 void Document::setDocumentURI(const String& uri)

Modified: trunk/Source/WebCore/dom/Document.h (234678 => 234679)

--- trunk/Source/WebCore/dom/Document.h	2018-08-07 23:26:48 UTC (rev 234678)
+++ trunk/Source/WebCore/dom/Document.h	2018-08-07 23:46:22 UTC (rev 234679)
@@ -475,8 +475,8 @@
 
     String xmlEncoding() const { return m_xmlEncoding; }
     String xmlVersion() const { return m_xmlVersion; }
-    enum StandaloneStatus { StandaloneUnspecified, Standalone, NotStandalone };
-    bool xmlStandalone() const { return m_xmlStandalone == Standalone; }
+    enum class StandaloneStatus : uint8_t { Unspecified, Standalone, NotStandalone };
+    bool xmlStandalone() const { return m_xmlStandalone == StandaloneStatus::Standalone; }
     StandaloneStatus xmlStandaloneStatus() const { return m_xmlStandalone; }
     bool hasXMLDeclaration() const { return m_hasXMLDeclaration; }
 
@@ -1682,7 +1682,7 @@
 
     String m_xmlEncoding;
     String m_xmlVersion;
-    StandaloneStatus m_xmlStandalone { StandaloneUnspecified };
+    StandaloneStatus m_xmlStandalone { StandaloneStatus::Unspecified };
     bool m_hasXMLDeclaration { false };
 
     String m_contentLanguage;

Modified: trunk/Source/WebCore/editing/MarkupAccumulator.cpp (234678 => 234679)

--- trunk/Source/WebCore/editing/MarkupAccumulator.cpp	2018-08-07 23:26:48 UTC (rev 234678)
+++ trunk/Source/WebCore/editing/MarkupAccumulator.cpp	2018-08-07 23:46:22 UTC (rev 234679)
@@ -376,7 +376,7 @@
         result.appendLiteral("\" encoding=\"");
         result.append(encoding);
     }
-    if (document.xmlStandaloneStatus() != Document::StandaloneUnspecified) {
+    if (document.xmlStandaloneStatus() != Document::StandaloneStatus::Unspecified) {
         result.appendLiteral("\" standalone=\"");
         if (document.xmlStandalone())
             result.appendLiteral("yes");

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes