Diff
Modified: trunk/Source/WebKit/ChangeLog (234729 => 234730)
--- trunk/Source/WebKit/ChangeLog 2018-08-09 18:18:44 UTC (rev 234729)
+++ trunk/Source/WebKit/ChangeLog 2018-08-09 18:48:14 UTC (rev 234730)
@@ -1,3 +1,28 @@
+2018-08-09 Sihui Liu <[email protected]>
+
+ REGRESSION (r232083): WKWebView loses first-party cookies on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=188443
+ <rdar://problem/42991584>
+
+ Reviewed by Chris Dumez.
+
+ Revert the change to set sharedCookieStorage for iOS as it is breaking Kayak.
+
+ * NetworkProcess/NetworkProcess.h:
+ * NetworkProcess/NetworkProcessCreationParameters.cpp:
+ (WebKit::NetworkProcessCreationParameters::encode const):
+ (WebKit::NetworkProcessCreationParameters::decode):
+ * NetworkProcess/NetworkProcessCreationParameters.h:
+ * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+ (WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
+ * Shared/WebProcessCreationParameters.cpp:
+ (WebKit::WebProcessCreationParameters::encode const):
+ (WebKit::WebProcessCreationParameters::decode):
+ * Shared/WebProcessCreationParameters.h:
+ * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+ (WebKit::WebProcessPool::platformInitializeWebProcess):
+ (WebKit::WebProcessPool::platformInitializeNetworkProcess):
+
2018-08-09 Per Arne Vollan <[email protected]>
DisplayRefreshMonitorMac should hold a weak pointer to WebPage.
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.h (234729 => 234730)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.h 2018-08-09 18:18:44 UTC (rev 234729)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.h 2018-08-09 18:48:14 UTC (rev 234730)
@@ -250,7 +250,7 @@
void setNetworkProxySettings(const WebCore::SoupNetworkProxySettings&);
#endif
-#if PLATFORM(COCOA)
+#if PLATFORM(MAC)
static void setSharedHTTPCookieStorage(const Vector<uint8_t>& identifier);
#endif
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp (234729 => 234730)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp 2018-08-09 18:18:44 UTC (rev 234729)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp 2018-08-09 18:48:14 UTC (rev 234730)
@@ -52,7 +52,7 @@
#if ENABLE(NETWORK_CACHE_SPECULATIVE_REVALIDATION)
encoder << shouldEnableNetworkCacheSpeculativeRevalidation;
#endif
-#if PLATFORM(COCOA)
+#if PLATFORM(MAC)
encoder << uiProcessCookieStorageIdentifier;
#endif
encoder << defaultSessionPendingCookies;
@@ -144,7 +144,7 @@
if (!decoder.decode(result.shouldEnableNetworkCacheSpeculativeRevalidation))
return false;
#endif
-#if PLATFORM(COCOA)
+#if PLATFORM(MAC)
if (!decoder.decode(result.uiProcessCookieStorageIdentifier))
return false;
#endif
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h (234729 => 234730)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h 2018-08-09 18:18:44 UTC (rev 234729)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h 2018-08-09 18:48:14 UTC (rev 234730)
@@ -63,7 +63,7 @@
#if ENABLE(NETWORK_CACHE_SPECULATIVE_REVALIDATION)
bool shouldEnableNetworkCacheSpeculativeRevalidation { false };
#endif
-#if PLATFORM(COCOA)
+#if PLATFORM(MAC)
Vector<uint8_t> uiProcessCookieStorageIdentifier;
#endif
Vector<WebCore::Cookie> defaultSessionPendingCookies;
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm (234729 => 234730)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2018-08-09 18:18:44 UTC (rev 234729)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2018-08-09 18:48:14 UTC (rev 234730)
@@ -96,7 +96,7 @@
initializeNetworkSettings();
-#if PLATFORM(COCOA)
+#if PLATFORM(MAC)
setSharedHTTPCookieStorage(parameters.uiProcessCookieStorageIdentifier);
#endif
@@ -192,7 +192,7 @@
}
}
-#if PLATFORM(COCOA)
+#if PLATFORM(MAC)
void NetworkProcess::setSharedHTTPCookieStorage(const Vector<uint8_t>& identifier)
{
ASSERT(hasProcessPrivilege(ProcessPrivilege::CanAccessRawCookies));
Modified: trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp (234729 => 234730)
--- trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp 2018-08-09 18:18:44 UTC (rev 234729)
+++ trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp 2018-08-09 18:48:14 UTC (rev 234730)
@@ -57,7 +57,7 @@
encoder << mediaCacheDirectoryExtensionHandle;
encoder << _javascript_ConfigurationDirectory;
encoder << _javascript_ConfigurationDirectoryExtensionHandle;
-#if PLATFORM(COCOA)
+#if PLATFORM(MAC)
encoder << uiProcessCookieStorageIdentifier;
#endif
#if PLATFORM(IOS)
@@ -216,7 +216,7 @@
return false;
parameters._javascript_ConfigurationDirectoryExtensionHandle = WTFMove(*_javascript_ConfigurationDirectoryExtensionHandle);
-#if PLATFORM(COCOA)
+#if PLATFORM(MAC)
if (!decoder.decode(parameters.uiProcessCookieStorageIdentifier))
return false;
#endif
Modified: trunk/Source/WebKit/Shared/WebProcessCreationParameters.h (234729 => 234730)
--- trunk/Source/WebKit/Shared/WebProcessCreationParameters.h 2018-08-09 18:18:44 UTC (rev 234729)
+++ trunk/Source/WebKit/Shared/WebProcessCreationParameters.h 2018-08-09 18:48:14 UTC (rev 234730)
@@ -84,7 +84,7 @@
SandboxExtension::Handle mediaCacheDirectoryExtensionHandle;
String _javascript_ConfigurationDirectory;
SandboxExtension::Handle _javascript_ConfigurationDirectoryExtensionHandle;
-#if PLATFORM(COCOA)
+#if PLATFORM(MAC)
Vector<uint8_t> uiProcessCookieStorageIdentifier;
#endif
#if PLATFORM(IOS)
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (234729 => 234730)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2018-08-09 18:18:44 UTC (rev 234729)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2018-08-09 18:48:14 UTC (rev 234730)
@@ -248,7 +248,7 @@
}
parameters.networkATSContext = adoptCF(_CFNetworkCopyATSContext());
-#if PLATFORM(COCOA)
+#if PLATFORM(MAC)
ASSERT(parameters.uiProcessCookieStorageIdentifier.isEmpty());
ASSERT(hasProcessPrivilege(ProcessPrivilege::CanAccessRawCookies));
parameters.uiProcessCookieStorageIdentifier = identifyingDataFromCookieStorage([[NSHTTPCookieStorage sharedHTTPCookieStorage] _cookieStorage]);
@@ -313,7 +313,7 @@
parameters.shouldSuppressMemoryPressureHandler = [defaults boolForKey:WebKitSuppressMemoryPressureHandlerDefaultsKey];
parameters.loadThrottleLatency = Seconds { [defaults integerForKey:WebKitNetworkLoadThrottleLatencyMillisecondsDefaultsKey] / 1000. };
-#if PLATFORM(COCOA)
+#if PLATFORM(MAC)
ASSERT(parameters.uiProcessCookieStorageIdentifier.isEmpty());
ASSERT(hasProcessPrivilege(ProcessPrivilege::CanAccessRawCookies));
parameters.uiProcessCookieStorageIdentifier = identifyingDataFromCookieStorage([[NSHTTPCookieStorage sharedHTTPCookieStorage] _cookieStorage]);
Modified: trunk/Tools/ChangeLog (234729 => 234730)
--- trunk/Tools/ChangeLog 2018-08-09 18:18:44 UTC (rev 234729)
+++ trunk/Tools/ChangeLog 2018-08-09 18:48:14 UTC (rev 234730)
@@ -1,3 +1,15 @@
+2018-08-09 Sihui Liu <[email protected]>
+
+ REGRESSION (r232083): WKWebView loses first-party cookies on iOS
+ https://bugs.webkit.org/show_bug.cgi?id=188443
+ <rdar://problem/42991584>
+
+ Reviewed by Chris Dumez.
+
+ Skip WebKit.WKHTTPCookieStoreWithoutProcessPool on iOS.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
+
2018-08-09 Ross Kirsling <[email protected]>
Unreviewed follow-up fix for r234720.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm (234729 => 234730)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm 2018-08-09 18:18:44 UTC (rev 234729)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm 2018-08-09 18:48:14 UTC (rev 234730)
@@ -476,6 +476,8 @@
}
@end
+// FIXME: on iOS, UI process should be using the same cookie file as the network process for default session.
+#if PLATFORM(MAC)
TEST(WebKit, WKHTTPCookieStoreWithoutProcessPool)
{
RetainPtr<NSHTTPCookie> sessionCookie = [NSHTTPCookie cookieWithProperties:@{
@@ -567,4 +569,5 @@
[webView loadHTMLString:alertCookieHTML baseURL:[NSURL URLWithString:@"http://127.0.0.1"]];
TestWebKitAPI::Util::run(&finished);
}
+#endif // PLATFORM(MAC)
#endif
