Title: [234741] trunk/Source/WebKit
Revision
234741
Author
[email protected]
Date
2018-08-09 16:07:24 -0700 (Thu, 09 Aug 2018)

Log Message

Fix URLSchemeHandler.SyncXHR API test after r234735.
https://bugs.webkit.org/show_bug.cgi?id=188358

* UIProcess/WebURLSchemeTask.cpp:
(WebKit::WebURLSchemeTask::didReceiveData):
Return after appending data for synchronous loads.  We used to send unused messages.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (234740 => 234741)


--- trunk/Source/WebKit/ChangeLog	2018-08-09 22:51:44 UTC (rev 234740)
+++ trunk/Source/WebKit/ChangeLog	2018-08-09 23:07:24 UTC (rev 234741)
@@ -1,5 +1,14 @@
 2018-08-09  Alex Christensen  <[email protected]>
 
+        Fix URLSchemeHandler.SyncXHR API test after r234735.
+        https://bugs.webkit.org/show_bug.cgi?id=188358
+
+        * UIProcess/WebURLSchemeTask.cpp:
+        (WebKit::WebURLSchemeTask::didReceiveData):
+        Return after appending data for synchronous loads.  We used to send unused messages.
+
+2018-08-09  Alex Christensen  <[email protected]>
+
         REGRESSION(234640) Loading stalls in environments without SafariSafeBrowsing framework
         https://bugs.webkit.org/show_bug.cgi?id=188453
         <rdar://problem/43102553>

Modified: trunk/Source/WebKit/UIProcess/WebURLSchemeTask.cpp (234740 => 234741)


--- trunk/Source/WebKit/UIProcess/WebURLSchemeTask.cpp	2018-08-09 22:51:44 UTC (rev 234740)
+++ trunk/Source/WebKit/UIProcess/WebURLSchemeTask.cpp	2018-08-09 23:07:24 UTC (rev 234741)
@@ -111,9 +111,10 @@
 
     if (isSync()) {
         if (m_syncData)
-            m_syncData->append(buffer);
+            m_syncData->append(WTFMove(buffer));
         else
             m_syncData = WTFMove(buffer);
+        return ExceptionType::None;
     }
 
     m_page->send(Messages::WebPage::URLSchemeTaskDidReceiveData(m_urlSchemeHandler->identifier(), m_identifier, IPC::SharedBufferDataReference(buffer.ptr())));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to