Title: [234770] trunk/Tools
- Revision
- 234770
- Author
- [email protected]
- Date
- 2018-08-10 14:48:41 -0700 (Fri, 10 Aug 2018)
Log Message
webkit-patch setup-git-clone should set Git core editor to commit-log-editor
https://bugs.webkit.org/show_bug.cgi?id=188473
Reviewed by Ryosuke Niwa.
Have "webkit-patch setup-git-clone" set the Git core editor to "perl Tools/Scripts/commit-log-editor --regenerate-log"
so that the Git commit message is generated from the ChangeLog for developers that manually
generate their ChangeLog using prepare-ChangeLog.
* Scripts/webkitpy/tool/commands/setupgitclone.py:
(SetupGitClone.execute):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (234769 => 234770)
--- trunk/Tools/ChangeLog 2018-08-10 20:29:43 UTC (rev 234769)
+++ trunk/Tools/ChangeLog 2018-08-10 21:48:41 UTC (rev 234770)
@@ -1,3 +1,17 @@
+2018-08-10 Daniel Bates <[email protected]>
+
+ webkit-patch setup-git-clone should set Git core editor to commit-log-editor
+ https://bugs.webkit.org/show_bug.cgi?id=188473
+
+ Reviewed by Ryosuke Niwa.
+
+ Have "webkit-patch setup-git-clone" set the Git core editor to "perl Tools/Scripts/commit-log-editor --regenerate-log"
+ so that the Git commit message is generated from the ChangeLog for developers that manually
+ generate their ChangeLog using prepare-ChangeLog.
+
+ * Scripts/webkitpy/tool/commands/setupgitclone.py:
+ (SetupGitClone.execute):
+
2018-08-10 Truitt Savell <[email protected]>
Unreviewed, rolling out r234749.
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/setupgitclone.py (234769 => 234770)
--- trunk/Tools/Scripts/webkitpy/tool/commands/setupgitclone.py 2018-08-10 20:29:43 UTC (rev 234769)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/setupgitclone.py 2018-08-10 21:48:41 UTC (rev 234770)
@@ -46,7 +46,7 @@
username, email = self._get_username_and_email(tool)
- # FIXME: We shouldn't be using a privatd method
+ # FIXME: We shouldn't be using a private method.
run_git = tool.scm()._run_git
run_git(["pull"])
run_git(["svn", "init", "--prefix=origin/", "-T", "trunk", "http://svn.webkit.org/repository/webkit"])
@@ -60,6 +60,8 @@
run_git(["config", "diff.objcpp.xfuncname", "^[-+@a-zA-Z_].*$"])
run_git(["config", "diff.objcppheader.xfuncname", "^[@a-zA-Z_].*$"])
+ run_git(["config", "core.editor", "perl Tools/Scripts/commit-log-editor --regenerate-log"])
+
if tool.user.confirm("Do you want to auto-color status, diff, and branch? (y/n)"):
run_git(["config", "color.status", "auto"])
run_git(["config", "color.diff", "auto"])
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
