- Revision
- 101453
- Author
- [email protected]
- Date
- 2011-11-30 00:07:45 -0800 (Wed, 30 Nov 2011)
Log Message
StorageEvent.key should not be nullable
https://bugs.webkit.org/show_bug.cgi?id=73125
Reviewed by Adam Barth.
Currently, document.createEvent('StorageEvent').key is evaluated as null.
However, the spec (http://www.whatwg.org/specs/web-apps/current-work/#storageevent)
says that StorageEvent.key is not a nullable type, and thus
document.createEvent('StorageEvent').key should be '' (an empty string).
Source/WebCore:
* storage/StorageEvent.idl: Removed a [ConvertNullStringTo=Null] IDL from StorageEvent.key.
LayoutTests:
* storage/domstorage/events/basic-body-attribute-expected.txt: Updated the test result as described above.
* storage/domstorage/events/basic-expected.txt: Ditto.
* storage/domstorage/events/basic-setattribute-expected.txt: Ditto.
* storage/domstorage/events/script-tests/basic-body-attribute.js: Ditto.
(step6):
* storage/domstorage/events/script-tests/basic-setattribute.js: Ditto.
(step6):
* storage/domstorage/events/script-tests/basic.js: Ditto.
(step6):
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (101452 => 101453)
--- trunk/LayoutTests/ChangeLog 2011-11-30 07:56:23 UTC (rev 101452)
+++ trunk/LayoutTests/ChangeLog 2011-11-30 08:07:45 UTC (rev 101453)
@@ -1,3 +1,25 @@
+2011-11-29 Kentaro Hara <[email protected]>
+
+ StorageEvent.key should not be nullable
+ https://bugs.webkit.org/show_bug.cgi?id=73125
+
+ Reviewed by Adam Barth.
+
+ Currently, document.createEvent('StorageEvent').key is evaluated as null.
+ However, the spec (http://www.whatwg.org/specs/web-apps/current-work/#storageevent)
+ says that StorageEvent.key is not a nullable type, and thus
+ document.createEvent('StorageEvent').key should be '' (an empty string).
+
+ * storage/domstorage/events/basic-body-attribute-expected.txt: Updated the test result as described above.
+ * storage/domstorage/events/basic-expected.txt: Ditto.
+ * storage/domstorage/events/basic-setattribute-expected.txt: Ditto.
+ * storage/domstorage/events/script-tests/basic-body-attribute.js: Ditto.
+ (step6):
+ * storage/domstorage/events/script-tests/basic-setattribute.js: Ditto.
+ (step6):
+ * storage/domstorage/events/script-tests/basic.js: Ditto.
+ (step6):
+
2011-11-29 Philip Rogers <[email protected]>
Fix for fill color not being applied inside visited links
Modified: trunk/LayoutTests/storage/domstorage/events/basic-body-attribute-expected.txt (101452 => 101453)
--- trunk/LayoutTests/storage/domstorage/events/basic-body-attribute-expected.txt 2011-11-30 07:56:23 UTC (rev 101452)
+++ trunk/LayoutTests/storage/domstorage/events/basic-body-attribute-expected.txt 2011-11-30 08:07:45 UTC (rev 101453)
@@ -44,7 +44,7 @@
PASS storageEventList[6].newValue is null
storage.clear()
PASS storageEventList.length is 8
-PASS storageEventList[7].key is null
+PASS storageEventList[7].key is ""
PASS storageEventList[7].oldValue is null
PASS storageEventList[7].newValue is null
@@ -90,7 +90,7 @@
PASS storageEventList[6].newValue is null
storage.clear()
PASS storageEventList.length is 8
-PASS storageEventList[7].key is null
+PASS storageEventList[7].key is ""
PASS storageEventList[7].oldValue is null
PASS storageEventList[7].newValue is null
Modified: trunk/LayoutTests/storage/domstorage/events/basic-expected.txt (101452 => 101453)
--- trunk/LayoutTests/storage/domstorage/events/basic-expected.txt 2011-11-30 07:56:23 UTC (rev 101452)
+++ trunk/LayoutTests/storage/domstorage/events/basic-expected.txt 2011-11-30 08:07:45 UTC (rev 101453)
@@ -42,7 +42,7 @@
PASS storageEventList[6].newValue is null
storage.clear()
PASS storageEventList.length is 8
-PASS storageEventList[7].key is null
+PASS storageEventList[7].key is ""
PASS storageEventList[7].oldValue is null
PASS storageEventList[7].newValue is null
@@ -86,7 +86,7 @@
PASS storageEventList[6].newValue is null
storage.clear()
PASS storageEventList.length is 8
-PASS storageEventList[7].key is null
+PASS storageEventList[7].key is ""
PASS storageEventList[7].oldValue is null
PASS storageEventList[7].newValue is null
Modified: trunk/LayoutTests/storage/domstorage/events/basic-setattribute-expected.txt (101452 => 101453)
--- trunk/LayoutTests/storage/domstorage/events/basic-setattribute-expected.txt 2011-11-30 07:56:23 UTC (rev 101452)
+++ trunk/LayoutTests/storage/domstorage/events/basic-setattribute-expected.txt 2011-11-30 08:07:45 UTC (rev 101453)
@@ -44,7 +44,7 @@
PASS storageEventList[6].newValue is null
storage.clear()
PASS storageEventList.length is 8
-PASS storageEventList[7].key is null
+PASS storageEventList[7].key is ""
PASS storageEventList[7].oldValue is null
PASS storageEventList[7].newValue is null
@@ -90,7 +90,7 @@
PASS storageEventList[6].newValue is null
storage.clear()
PASS storageEventList.length is 8
-PASS storageEventList[7].key is null
+PASS storageEventList[7].key is ""
PASS storageEventList[7].oldValue is null
PASS storageEventList[7].newValue is null
Modified: trunk/LayoutTests/storage/domstorage/events/script-tests/basic-body-attribute.js (101452 => 101453)
--- trunk/LayoutTests/storage/domstorage/events/script-tests/basic-body-attribute.js 2011-11-30 07:56:23 UTC (rev 101452)
+++ trunk/LayoutTests/storage/domstorage/events/script-tests/basic-body-attribute.js 2011-11-30 08:07:45 UTC (rev 101453)
@@ -86,7 +86,7 @@
function step6()
{
shouldBe("storageEventList.length", "8");
- shouldBeNull("storageEventList[7].key");
+ shouldBeEqualToString("storageEventList[7].key", "");
shouldBeNull("storageEventList[7].oldValue");
shouldBeNull("storageEventList[7].newValue");
Modified: trunk/LayoutTests/storage/domstorage/events/script-tests/basic-setattribute.js (101452 => 101453)
--- trunk/LayoutTests/storage/domstorage/events/script-tests/basic-setattribute.js 2011-11-30 07:56:23 UTC (rev 101452)
+++ trunk/LayoutTests/storage/domstorage/events/script-tests/basic-setattribute.js 2011-11-30 08:07:45 UTC (rev 101453)
@@ -86,7 +86,7 @@
function step6()
{
shouldBe("storageEventList.length", "8");
- shouldBeNull("storageEventList[7].key");
+ shouldBeEqualToString("storageEventList[7].key", "");
shouldBeNull("storageEventList[7].oldValue");
shouldBeNull("storageEventList[7].newValue");
Modified: trunk/LayoutTests/storage/domstorage/events/script-tests/basic.js (101452 => 101453)
--- trunk/LayoutTests/storage/domstorage/events/script-tests/basic.js 2011-11-30 07:56:23 UTC (rev 101452)
+++ trunk/LayoutTests/storage/domstorage/events/script-tests/basic.js 2011-11-30 08:07:45 UTC (rev 101453)
@@ -86,7 +86,7 @@
function step6()
{
shouldBe("storageEventList.length", "8");
- shouldBeNull("storageEventList[7].key");
+ shouldBeEqualToString("storageEventList[7].key", "");
shouldBeNull("storageEventList[7].oldValue");
shouldBeNull("storageEventList[7].newValue");
Modified: trunk/Source/WebCore/ChangeLog (101452 => 101453)
--- trunk/Source/WebCore/ChangeLog 2011-11-30 07:56:23 UTC (rev 101452)
+++ trunk/Source/WebCore/ChangeLog 2011-11-30 08:07:45 UTC (rev 101453)
@@ -1,3 +1,17 @@
+2011-11-29 Kentaro Hara <[email protected]>
+
+ StorageEvent.key should not be nullable
+ https://bugs.webkit.org/show_bug.cgi?id=73125
+
+ Reviewed by Adam Barth.
+
+ Currently, document.createEvent('StorageEvent').key is evaluated as null.
+ However, the spec (http://www.whatwg.org/specs/web-apps/current-work/#storageevent)
+ says that StorageEvent.key is not a nullable type, and thus
+ document.createEvent('StorageEvent').key should be '' (an empty string).
+
+ * storage/StorageEvent.idl: Removed a [ConvertNullStringTo=Null] IDL from StorageEvent.key.
+
2011-11-29 Philip Rogers <[email protected]>
Fix for fill color not being applied inside visited links
Modified: trunk/Source/WebCore/storage/StorageEvent.idl (101452 => 101453)
--- trunk/Source/WebCore/storage/StorageEvent.idl 2011-11-30 07:56:23 UTC (rev 101452)
+++ trunk/Source/WebCore/storage/StorageEvent.idl 2011-11-30 08:07:45 UTC (rev 101453)
@@ -26,7 +26,7 @@
module storage {
interface StorageEvent : Event {
- readonly attribute [ConvertNullStringTo=Null] DOMString key;
+ readonly attribute DOMString key;
readonly attribute [ConvertNullStringTo=Null] DOMString oldValue;
readonly attribute [ConvertNullStringTo=Null] DOMString newValue;
readonly attribute DOMString url;
