Title: [234779] trunk/LayoutTests
- Revision
- 234779
- Author
- [email protected]
- Date
- 2018-08-10 19:21:10 -0700 (Fri, 10 Aug 2018)
Log Message
LayoutTest inspector/worker/debugger-pause.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=164833
<rdar://problem/29295404>
Patch by Joseph Pecoraro <[email protected]> on 2018-08-10
Reviewed by Brian Burg.
* inspector/worker/debugger-pause.html:
Add a microtask turn to ensure the workerTarget's mainResource is setup.
There were times it might not get setup, but a single turn appears
reliable enough.
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
This test always passes for me in Release and Debug. Reset expectations.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (234778 => 234779)
--- trunk/LayoutTests/ChangeLog 2018-08-11 02:01:24 UTC (rev 234778)
+++ trunk/LayoutTests/ChangeLog 2018-08-11 02:21:10 UTC (rev 234779)
@@ -1,3 +1,20 @@
+2018-08-10 Joseph Pecoraro <[email protected]>
+
+ LayoutTest inspector/worker/debugger-pause.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=164833
+ <rdar://problem/29295404>
+
+ Reviewed by Brian Burg.
+
+ * inspector/worker/debugger-pause.html:
+ Add a microtask turn to ensure the workerTarget's mainResource is setup.
+ There were times it might not get setup, but a single turn appears
+ reliable enough.
+
+ * platform/gtk/TestExpectations:
+ * platform/mac/TestExpectations:
+ This test always passes for me in Release and Debug. Reset expectations.
+
2018-08-10 Chris Dumez <[email protected]>
Crash under NetworkResourceLoader::convertToDownload()
Modified: trunk/LayoutTests/inspector/worker/debugger-pause.html (234778 => 234779)
--- trunk/LayoutTests/inspector/worker/debugger-pause.html 2018-08-11 02:01:24 UTC (rev 234778)
+++ trunk/LayoutTests/inspector/worker/debugger-pause.html 2018-08-11 02:21:10 UTC (rev 234779)
@@ -111,8 +111,11 @@
}
});
- window.loadLinesFromSourceCode(workerTarget.mainResource).then(() => {
- suite.runTestCasesAndFinish();
+ // Turn once to ensure workerTarget.mainResource is loaded.
+ Promise.resolve().then(() => {
+ window.loadLinesFromSourceCode(workerTarget.mainResource).then(() => {
+ suite.runTestCasesAndFinish();
+ });
});
}
</script>
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (234778 => 234779)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2018-08-11 02:01:24 UTC (rev 234778)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2018-08-11 02:21:10 UTC (rev 234779)
@@ -1841,8 +1841,6 @@
webkit.org/b/172815 imported/w3c/i18n/bidi/bidi-plaintext-011.html [ Pass ImageOnlyFailure ]
-webkit.org/b/164833 inspector/worker/debugger-pause.html [ Pass Failure Timeout ]
-
webkit.org/b/173412 fast/scrolling/overflow-scrollable-after-back.html [ Pass Failure ]
webkit.org/b/168373 media/video-seek-past-end-paused.html [ Failure Pass ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (234778 => 234779)
--- trunk/LayoutTests/platform/mac/TestExpectations 2018-08-11 02:01:24 UTC (rev 234778)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2018-08-11 02:21:10 UTC (rev 234779)
@@ -1102,7 +1102,6 @@
webkit.org/b/161361 inspector/unit-tests/yieldable-task.html [ Pass Failure ]
webkit.org/b/169228 inspector/worker/console-basic.html [ Pass Timeout ]
webkit.org/b/164872 inspector/worker/debugger-multiple-targets-pause.html [ Pass Failure Timeout ]
-webkit.org/b/164833 inspector/worker/debugger-pause.html [ Pass Failure Timeout ]
webkit.org/b/165582 inspector/worker/debugger-scripts.html [ Pass Failure ]
webkit.org/b/167203 inspector/worker/debugger-shared-breakpoint.html [ Pass Failure Timeout ]
webkit.org/b/155607 inspector/heap/snapshot.html [ Pass Timeout ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
