Title: [234781] trunk/Source/WebKit
- Revision
- 234781
- Author
- [email protected]
- Date
- 2018-08-10 19:55:23 -0700 (Fri, 10 Aug 2018)
Log Message
[Cocoa] WebKit::PlatformPopupMenuData should use member initialization
<https://webkit.org/b/188478>
<rdar://problem/43154363>
Reviewed by Joseph Pecoraro.
* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::PlatformPopupMenuData): Delete
implementation. This constructor caused the warning by never
initializing its member variables.
* Shared/PlatformPopupMenuData.h:
(WebKit::PlatformPopupMenuData::PlatformPopupMenuData):
- Use default constructor.
(WebKit::PlatformPopupMenuData::shouldPopOver):
(WebKit::PlatformPopupMenuData::hideArrows):
(WebKit::PlatformPopupMenuData::menuSize):
- Add struct member initialization.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (234780 => 234781)
--- trunk/Source/WebKit/ChangeLog 2018-08-11 02:43:47 UTC (rev 234780)
+++ trunk/Source/WebKit/ChangeLog 2018-08-11 02:55:23 UTC (rev 234781)
@@ -1,3 +1,23 @@
+2018-08-10 David Kilzer <[email protected]>
+
+ [Cocoa] WebKit::PlatformPopupMenuData should use member initialization
+ <https://webkit.org/b/188478>
+ <rdar://problem/43154363>
+
+ Reviewed by Joseph Pecoraro.
+
+ * Shared/PlatformPopupMenuData.cpp:
+ (WebKit::PlatformPopupMenuData::PlatformPopupMenuData): Delete
+ implementation. This constructor caused the warning by never
+ initializing its member variables.
+ * Shared/PlatformPopupMenuData.h:
+ (WebKit::PlatformPopupMenuData::PlatformPopupMenuData):
+ - Use default constructor.
+ (WebKit::PlatformPopupMenuData::shouldPopOver):
+ (WebKit::PlatformPopupMenuData::hideArrows):
+ (WebKit::PlatformPopupMenuData::menuSize):
+ - Add struct member initialization.
+
2018-08-10 Chris Dumez <[email protected]>
Crash under NetworkResourceLoader::convertToDownload()
Modified: trunk/Source/WebKit/Shared/PlatformPopupMenuData.cpp (234780 => 234781)
--- trunk/Source/WebKit/Shared/PlatformPopupMenuData.cpp 2018-08-11 02:43:47 UTC (rev 234780)
+++ trunk/Source/WebKit/Shared/PlatformPopupMenuData.cpp 2018-08-11 02:55:23 UTC (rev 234781)
@@ -30,10 +30,6 @@
namespace WebKit {
-PlatformPopupMenuData::PlatformPopupMenuData()
-{
-}
-
void PlatformPopupMenuData::encode(IPC::Encoder& encoder) const
{
#if PLATFORM(COCOA)
Modified: trunk/Source/WebKit/Shared/PlatformPopupMenuData.h (234780 => 234781)
--- trunk/Source/WebKit/Shared/PlatformPopupMenuData.h 2018-08-11 02:43:47 UTC (rev 234780)
+++ trunk/Source/WebKit/Shared/PlatformPopupMenuData.h 2018-08-11 02:55:23 UTC (rev 234781)
@@ -38,7 +38,7 @@
namespace WebKit {
struct PlatformPopupMenuData {
- PlatformPopupMenuData();
+ PlatformPopupMenuData() = default;
void encode(IPC::Encoder&) const;
static bool decode(IPC::Decoder&, PlatformPopupMenuData&);
@@ -46,9 +46,9 @@
#if PLATFORM(COCOA)
FontInfo fontInfo;
- bool shouldPopOver;
- bool hideArrows;
- WebCore::PopupMenuStyle::PopupMenuSize menuSize;
+ bool shouldPopOver { false };
+ bool hideArrows { false };
+ WebCore::PopupMenuStyle::PopupMenuSize menuSize { WebCore::PopupMenuStyle::PopupMenuSize::PopupMenuSizeNormal };
#elif PLATFORM(WIN)
int m_clientPaddingLeft { 0 };
int m_clientPaddingRight { 0 };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
