Title: [234792] trunk/Source/WebDriver
- Revision
- 234792
- Author
- [email protected]
- Date
- 2018-08-12 23:47:18 -0700 (Sun, 12 Aug 2018)
Log Message
WebDriver: do not handle prompts that appear while running scripts
https://bugs.webkit.org/show_bug.cgi?id=188468
Reviewed by Žan Doberšek.
This changed in the spec, we should just finish the script without handling the alert at all.
https://github.com/w3c/webdriver/commit/afb578090bc95718debeab6a6821da8d12b952c8
"If at any point during the algorithm a user prompt appears, abort all subsequent substeps of this algorithm,
and return success with data null."
https://w3c.github.io/webdriver/#dfn-execute-a-function-body
* Session.cpp:
(WebDriver::Session::executeScript):
Modified Paths
Diff
Modified: trunk/Source/WebDriver/ChangeLog (234791 => 234792)
--- trunk/Source/WebDriver/ChangeLog 2018-08-13 06:33:08 UTC (rev 234791)
+++ trunk/Source/WebDriver/ChangeLog 2018-08-13 06:47:18 UTC (rev 234792)
@@ -1,3 +1,20 @@
+2018-08-12 Carlos Garcia Campos <[email protected]>
+
+ WebDriver: do not handle prompts that appear while running scripts
+ https://bugs.webkit.org/show_bug.cgi?id=188468
+
+ Reviewed by Žan Doberšek.
+
+ This changed in the spec, we should just finish the script without handling the alert at all.
+ https://github.com/w3c/webdriver/commit/afb578090bc95718debeab6a6821da8d12b952c8
+
+ "If at any point during the algorithm a user prompt appears, abort all subsequent substeps of this algorithm,
+ and return success with data null."
+ https://w3c.github.io/webdriver/#dfn-execute-a-function-body
+
+ * Session.cpp:
+ (WebDriver::Session::executeScript):
+
2018-08-10 Carlos Garcia Campos <[email protected]>
[GTK][WPE] WebDriver: do not use default browser arguments when browser binary has been provided
Modified: trunk/Source/WebDriver/Session.cpp (234791 => 234792)
--- trunk/Source/WebDriver/Session.cpp 2018-08-13 06:33:08 UTC (rev 234791)
+++ trunk/Source/WebDriver/Session.cpp 2018-08-13 06:47:18 UTC (rev 234792)
@@ -1859,7 +1859,7 @@
if (response.isError || !response.responseObject) {
auto result = CommandResult::fail(WTFMove(response.responseObject));
if (result.errorCode() == CommandResult::ErrorCode::UnexpectedAlertOpen)
- handleUnexpectedAlertOpen(WTFMove(completionHandler));
+ completionHandler(CommandResult::success());
else
completionHandler(WTFMove(result));
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
