Title: [234799] trunk
- Revision
- 234799
- Author
- [email protected]
- Date
- 2018-08-13 06:31:50 -0700 (Mon, 13 Aug 2018)
Log Message
Expose CloseEvent and CustomEvent to workers
https://bugs.webkit.org/show_bug.cgi?id=188493
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
* web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt:
Source/WebCore:
This patch exposes CloseEvent and CustomEvent to workers.
It is OK since they do not depend on things in the main thread.
For example, we cannot expose FormData right now since it depends
on Page.
We do not expose PromiseRejectionEvent in this patch since it will
be done in [1].
[1]: https://bugs.webkit.org/show_bug.cgi?id=188265
* Modules/websockets/CloseEvent.idl:
* dom/CustomEvent.idl:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (234798 => 234799)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2018-08-13 13:18:20 UTC (rev 234798)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-08-13 13:31:50 UTC (rev 234799)
@@ -1,3 +1,12 @@
+2018-08-13 Yusuke Suzuki <[email protected]>
+
+ Expose CloseEvent and CustomEvent to workers
+ https://bugs.webkit.org/show_bug.cgi?id=188493
+
+ Reviewed by Sam Weinig.
+
+ * web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt:
+
2018-08-13 Oriol Brufau <[email protected]>
[css-logical] Implement flow-relative margin, padding, border and sizing properties
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt (234798 => 234799)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt 2018-08-13 13:18:20 UTC (rev 234798)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/interface-objects/001.worker-expected.txt 2018-08-13 13:31:50 UTC (rev 234799)
@@ -15,7 +15,7 @@
FAIL The PromiseRejectionEvent interface object should be exposed. assert_own_property: expected property "PromiseRejectionEvent" missing
PASS The EventSource interface object should be exposed.
PASS The WebSocket interface object should be exposed.
-FAIL The CloseEvent interface object should be exposed. assert_own_property: expected property "CloseEvent" missing
+PASS The CloseEvent interface object should be exposed.
FAIL The BroadcastChannel interface object should be exposed. assert_own_property: expected property "BroadcastChannel" missing
PASS The ArrayBuffer interface object should be exposed.
PASS The Int8Array interface object should be exposed.
@@ -43,7 +43,7 @@
PASS The EventTarget interface object should be exposed.
PASS The ErrorEvent interface object should be exposed.
PASS The Event interface object should be exposed.
-FAIL The CustomEvent interface object should be exposed. assert_own_property: expected property "CustomEvent" missing
+PASS The CustomEvent interface object should be exposed.
PASS The DOMException interface object should be exposed.
PASS The ReadableStream interface object should be exposed.
FAIL The WritableStream interface object should be exposed. assert_own_property: expected property "WritableStream" missing
Modified: trunk/Source/WebCore/ChangeLog (234798 => 234799)
--- trunk/Source/WebCore/ChangeLog 2018-08-13 13:18:20 UTC (rev 234798)
+++ trunk/Source/WebCore/ChangeLog 2018-08-13 13:31:50 UTC (rev 234799)
@@ -1,3 +1,23 @@
+2018-08-13 Yusuke Suzuki <[email protected]>
+
+ Expose CloseEvent and CustomEvent to workers
+ https://bugs.webkit.org/show_bug.cgi?id=188493
+
+ Reviewed by Sam Weinig.
+
+ This patch exposes CloseEvent and CustomEvent to workers.
+ It is OK since they do not depend on things in the main thread.
+ For example, we cannot expose FormData right now since it depends
+ on Page.
+
+ We do not expose PromiseRejectionEvent in this patch since it will
+ be done in [1].
+
+ [1]: https://bugs.webkit.org/show_bug.cgi?id=188265
+
+ * Modules/websockets/CloseEvent.idl:
+ * dom/CustomEvent.idl:
+
2018-08-13 Oriol Brufau <[email protected]>
[css-logical] Implement flow-relative margin, padding, border and sizing properties
Modified: trunk/Source/WebCore/Modules/websockets/CloseEvent.idl (234798 => 234799)
--- trunk/Source/WebCore/Modules/websockets/CloseEvent.idl 2018-08-13 13:18:20 UTC (rev 234798)
+++ trunk/Source/WebCore/Modules/websockets/CloseEvent.idl 2018-08-13 13:31:50 UTC (rev 234799)
@@ -28,9 +28,9 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// FIXME: This should be exposed to workers as well.
[
Constructor(DOMString type, optional CloseEventInit eventInitDict),
+ Exposed=(Window,Worker),
] interface CloseEvent : Event {
readonly attribute boolean wasClean;
readonly attribute unsigned short code;
Modified: trunk/Source/WebCore/dom/CustomEvent.idl (234798 => 234799)
--- trunk/Source/WebCore/dom/CustomEvent.idl 2018-08-13 13:18:20 UTC (rev 234798)
+++ trunk/Source/WebCore/dom/CustomEvent.idl 2018-08-13 13:31:50 UTC (rev 234799)
@@ -24,9 +24,9 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-// FIXME: This should be exposed to workers as well.
[
Constructor(DOMString type, optional CustomEventInit eventInitDict),
+ Exposed=(Window,Worker),
JSCustomMarkFunction,
] interface CustomEvent : Event {
[CustomGetter] readonly attribute any detail;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
