Title: [234815] trunk/Source/WebCore
- Revision
- 234815
- Author
- [email protected]
- Date
- 2018-08-13 13:18:05 -0700 (Mon, 13 Aug 2018)
Log Message
Remove unused code in CSSParserSelector/CSSSelector
https://bugs.webkit.org/show_bug.cgi?id=188528
Reviewed by Simon Fraser.
* css/CSSSelector.cpp:
* css/CSSSelector.h:
(WebCore::CSSSelector::serializingValue const):
(WebCore::CSSSelector::setAttributeValueMatchingIsCaseInsensitive): Deleted.
* css/parser/CSSParserSelector.h:
(WebCore::CSSParserSelector::setAttributeValueMatchingIsCaseInsensitive): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (234814 => 234815)
--- trunk/Source/WebCore/ChangeLog 2018-08-13 20:17:09 UTC (rev 234814)
+++ trunk/Source/WebCore/ChangeLog 2018-08-13 20:18:05 UTC (rev 234815)
@@ -1,5 +1,19 @@
2018-08-13 Alex Christensen <[email protected]>
+ Remove unused code in CSSParserSelector/CSSSelector
+ https://bugs.webkit.org/show_bug.cgi?id=188528
+
+ Reviewed by Simon Fraser.
+
+ * css/CSSSelector.cpp:
+ * css/CSSSelector.h:
+ (WebCore::CSSSelector::serializingValue const):
+ (WebCore::CSSSelector::setAttributeValueMatchingIsCaseInsensitive): Deleted.
+ * css/parser/CSSParserSelector.h:
+ (WebCore::CSSParserSelector::setAttributeValueMatchingIsCaseInsensitive): Deleted.
+
+2018-08-13 Alex Christensen <[email protected]>
+
Modernize CSSSelectorList a little
https://bugs.webkit.org/show_bug.cgi?id=188527
Modified: trunk/Source/WebCore/css/CSSSelector.cpp (234814 => 234815)
--- trunk/Source/WebCore/css/CSSSelector.cpp 2018-08-13 20:17:09 UTC (rev 234814)
+++ trunk/Source/WebCore/css/CSSSelector.cpp 2018-08-13 20:18:05 UTC (rev 234815)
@@ -751,13 +751,6 @@
return str.toString() + rightSide;
}
-void CSSSelector::setAttribute(const QualifiedName& value, bool isCaseInsensitive)
-{
- createRareData();
- m_data.m_rareData->m_attribute = value;
- m_data.m_rareData->m_attributeCanonicalLocalName = isCaseInsensitive ? value.localName().convertToASCIILowercase() : value.localName();
-}
-
void CSSSelector::setAttribute(const QualifiedName& value, bool convertToLowercase, AttributeMatchType matchType)
{
createRareData();
Modified: trunk/Source/WebCore/css/CSSSelector.h (234814 => 234815)
--- trunk/Source/WebCore/css/CSSSelector.h 2018-08-13 20:17:09 UTC (rev 234814)
+++ trunk/Source/WebCore/css/CSSSelector.h 2018-08-13 20:18:05 UTC (rev 234815)
@@ -242,9 +242,6 @@
void setValue(const AtomicString&, bool matchLowerCase = false);
- // FIXME-NEWPARSER: These two methods can go away once the old parser is gone.
- void setAttribute(const QualifiedName&, bool);
- void setAttributeValueMatchingIsCaseInsensitive(bool);
void setAttribute(const QualifiedName&, bool convertToLowercase, AttributeMatchType);
void setNth(int a, int b);
void setArgument(const AtomicString&);
@@ -587,12 +584,6 @@
// AtomicString is really just an AtomicStringImpl* so the cast below is safe.
return *reinterpret_cast<const AtomicString*>(&m_data.m_value);
}
-
-inline void CSSSelector::setAttributeValueMatchingIsCaseInsensitive(bool isCaseInsensitive)
-{
- ASSERT(isAttributeSelector() && match() != CSSSelector::Set);
- m_caseInsensitiveAttributeValueMatching = isCaseInsensitive;
-}
inline bool CSSSelector::attributeValueMatchingIsCaseInsensitive() const
{
Modified: trunk/Source/WebCore/css/parser/CSSParserSelector.h (234814 => 234815)
--- trunk/Source/WebCore/css/parser/CSSParserSelector.h 2018-08-13 20:17:09 UTC (rev 234814)
+++ trunk/Source/WebCore/css/parser/CSSParserSelector.h 2018-08-13 20:18:05 UTC (rev 234815)
@@ -52,11 +52,7 @@
std::unique_ptr<CSSSelector> releaseSelector() { return WTFMove(m_selector); }
void setValue(const AtomicString& value, bool matchLowerCase = false) { m_selector->setValue(value, matchLowerCase); }
-
- // FIXME-NEWPARSER: These two methods can go away once old parser is gone.
- void setAttribute(const QualifiedName& value, bool isCaseInsensitive) { m_selector->setAttribute(value, isCaseInsensitive); }
- void setAttributeValueMatchingIsCaseInsensitive(bool isCaseInsensitive) { m_selector->setAttributeValueMatchingIsCaseInsensitive(isCaseInsensitive); }
-
+
void setAttribute(const QualifiedName& value, bool convertToLowercase, CSSSelector::AttributeMatchType type) { m_selector->setAttribute(value, convertToLowercase, type); }
void setArgument(const AtomicString& value) { m_selector->setArgument(value); }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
