Title: [234851] trunk/Source/WebCore
- Revision
- 234851
- Author
- [email protected]
- Date
- 2018-08-14 10:12:14 -0700 (Tue, 14 Aug 2018)
Log Message
Follow-up: [IntersectionObserver] Implement rootMargin parsing
https://bugs.webkit.org/show_bug.cgi?id=188469
Address review feedback from Darin Adler.
* page/IntersectionObserver.cpp:
(WebCore::IntersectionObserver::rootMargin const):
Use StringBuilder::appendLiteral instead of ::append to append a literal.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (234850 => 234851)
--- trunk/Source/WebCore/ChangeLog 2018-08-14 16:53:08 UTC (rev 234850)
+++ trunk/Source/WebCore/ChangeLog 2018-08-14 17:12:14 UTC (rev 234851)
@@ -1,3 +1,14 @@
+2018-08-14 Ali Juma <[email protected]>
+
+ Follow-up: [IntersectionObserver] Implement rootMargin parsing
+ https://bugs.webkit.org/show_bug.cgi?id=188469
+
+ Address review feedback from Darin Adler.
+
+ * page/IntersectionObserver.cpp:
+ (WebCore::IntersectionObserver::rootMargin const):
+ Use StringBuilder::appendLiteral instead of ::append to append a literal.
+
2018-08-14 Antoine Quint <[email protected]>
[Web Animations] Crash under AnimationTimeline::cancelOrRemoveDeclarativeAnimation()
Modified: trunk/Source/WebCore/page/IntersectionObserver.cpp (234850 => 234851)
--- trunk/Source/WebCore/page/IntersectionObserver.cpp 2018-08-14 16:53:08 UTC (rev 234850)
+++ trunk/Source/WebCore/page/IntersectionObserver.cpp 2018-08-14 17:12:14 UTC (rev 234851)
@@ -121,7 +121,7 @@
if (length.type() == Percent)
stringBuilder.append('%');
else
- stringBuilder.append("px", 2);
+ stringBuilder.appendLiteral("px");
if (side != PhysicalBoxSide::Left)
stringBuilder.append(' ');
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
