Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (234860 => 234861)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2018-08-14 19:04:56 UTC (rev 234860)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2018-08-14 20:13:39 UTC (rev 234861)
@@ -423,6 +423,13 @@
return shell.Test.start(self)
+class RunWebKit1Tests(RunWebKitTests):
+ def start(self):
+ self.setCommand(self.command + ['--dump-render-tree'])
+
+ return RunWebKitTests.start(self)
+
+
class ArchiveBuiltProduct(shell.ShellCommand):
command = ['python', 'Tools/BuildSlaveSupport/built-product-archive',
WithProperties('--platform=%(fullPlatform)s'), WithProperties('--%(configuration)s'), 'archive']
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (234860 => 234861)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2018-08-14 19:04:56 UTC (rev 234860)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2018-08-14 20:13:39 UTC (rev 234861)
@@ -756,6 +756,42 @@
return self.runStep()
+class TestRunWebKit1Tests(BuildStepMixinAdditions, unittest.TestCase):
+ def setUp(self):
+ self.longMessage = True
+ return self.setUpBuildStep()
+
+ def tearDown(self):
+ return self.tearDownBuildStep()
+
+ def test_success(self):
+ self.setupStep(RunWebKit1Tests())
+ self.setProperty('fullPlatform', 'ios-11')
+ self.setProperty('configuration', 'debug')
+ self.expectRemoteCommands(
+ ExpectShell(workdir='wkdir',
+ command=['python', 'Tools/Scripts/run-webkit-tests', '--no-build', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures', '30', '--skip-failing-tests', '--debug', '--dump-render-tree', '--results-directory', 'layout-test-results', '--debug-rwt-logging'],
+ )
+ + 0,
+ )
+ self.expectOutcome(result=SUCCESS, state_string='layout-tests')
+ return self.runStep()
+
+ def test_failure(self):
+ self.setupStep(RunWebKit1Tests())
+ self.setProperty('fullPlatform', 'ios-11')
+ self.setProperty('configuration', 'release')
+ self.expectRemoteCommands(
+ ExpectShell(workdir='wkdir',
+ command=['python', 'Tools/Scripts/run-webkit-tests', '--no-build', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures', '30', '--skip-failing-tests', '--release', '--dump-render-tree', '--results-directory', 'layout-test-results', '--debug-rwt-logging'],
+ )
+ + ExpectShell.log('stdio', stdout='9 failures found.')
+ + 2,
+ )
+ self.expectOutcome(result=FAILURE, state_string='layout-tests (failure)')
+ return self.runStep()
+
+
class TestArchiveBuiltProduct(BuildStepMixinAdditions, unittest.TestCase):
def setUp(self):
self.longMessage = True
Modified: trunk/Tools/ChangeLog (234860 => 234861)
--- trunk/Tools/ChangeLog 2018-08-14 19:04:56 UTC (rev 234860)
+++ trunk/Tools/ChangeLog 2018-08-14 20:13:39 UTC (rev 234861)
@@ -1,3 +1,14 @@
+2018-08-14 Aakash Jain <[email protected]>
+
+ [ews-build] Add build step to run WK1 layout-test
+ https://bugs.webkit.org/show_bug.cgi?id=188498
+
+ Reviewed by Lucas Forschler.
+
+ * BuildSlaveSupport/ews-build/steps.py:
+ (RunWebKit1Tests): Class to run WebKit1Tests.
+ * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
+
2018-08-14 Patrick Griffis <[email protected]>
[Flatpak] Fix --cmakeargs