Title: [234865] trunk/Source/WebKit
- Revision
- 234865
- Author
- [email protected]
- Date
- 2018-08-14 16:22:09 -0700 (Tue, 14 Aug 2018)
Log Message
Remove api misuse check so that custom webcontent service identifier can be set at runtime
https://bugs.webkit.org/show_bug.cgi?id=188579
Patch by Ben Richards <[email protected]> on 2018-08-14
Reviewed by Ryosuke Niwa.
Changed API misuse check so that a custom bundle identifier can be set at runtime with a debug flag
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setCustomWebContentServiceBundleIdentifier):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getLaunchOptions):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (234864 => 234865)
--- trunk/Source/WebKit/ChangeLog 2018-08-14 23:17:13 UTC (rev 234864)
+++ trunk/Source/WebKit/ChangeLog 2018-08-14 23:22:09 UTC (rev 234865)
@@ -1,3 +1,17 @@
+2018-08-14 Ben Richards <[email protected]>
+
+ Remove api misuse check so that custom webcontent service identifier can be set at runtime
+ https://bugs.webkit.org/show_bug.cgi?id=188579
+
+ Reviewed by Ryosuke Niwa.
+
+ Changed API misuse check so that a custom bundle identifier can be set at runtime with a debug flag
+
+ * UIProcess/WebProcessPool.cpp:
+ (WebKit::WebProcessPool::setCustomWebContentServiceBundleIdentifier):
+ * UIProcess/WebProcessProxy.cpp:
+ (WebKit::WebProcessProxy::getLaunchOptions):
+
2018-08-14 Antti Koivisto <[email protected]>
RemoteLayerTreeTransaction should use OptionSet for change flags
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (234864 => 234865)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2018-08-14 23:17:13 UTC (rev 234864)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2018-08-14 23:22:09 UTC (rev 234865)
@@ -421,7 +421,7 @@
void WebProcessPool::setCustomWebContentServiceBundleIdentifier(const String& customWebContentServiceBundleIdentifier)
{
// Guard against API misuse.
- if (m_processes.size() || !customWebContentServiceBundleIdentifier.isAllASCII())
+ if (!customWebContentServiceBundleIdentifier.isAllASCII())
CRASH();
m_configuration->setCustomWebContentServiceBundleIdentifier(customWebContentServiceBundleIdentifier);
Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp (234864 => 234865)
--- trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp 2018-08-14 23:17:13 UTC (rev 234864)
+++ trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp 2018-08-14 23:22:09 UTC (rev 234865)
@@ -162,7 +162,7 @@
ChildProcessProxy::getLaunchOptions(launchOptions);
- if (!m_processPool->customWebContentServiceBundleIdentifier().isNull())
+ if (!m_processPool->customWebContentServiceBundleIdentifier().isEmpty())
launchOptions.customWebContentServiceBundleIdentifier = m_processPool->customWebContentServiceBundleIdentifier().ascii();
if (WebKit::isInspectorProcessPool(processPool()))
launchOptions.extraInitializationData.add("inspector-process"_s, "1"_s);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
