Title: [234882] trunk/Source/WebInspectorUI
- Revision
- 234882
- Author
- [email protected]
- Date
- 2018-08-14 23:10:34 -0700 (Tue, 14 Aug 2018)
Log Message
Web Inspector: Table should not center rows when scrolling them into view
https://bugs.webkit.org/show_bug.cgi?id=188593
<rdar://problem/43311660>
Reviewed by Devin Rousso.
* UserInterface/Views/Table.js:
(WI.Table.prototype._handleKeyDown):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (234881 => 234882)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-08-15 04:47:16 UTC (rev 234881)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-08-15 06:10:34 UTC (rev 234882)
@@ -1,3 +1,14 @@
+2018-08-14 Matt Baker <[email protected]>
+
+ Web Inspector: Table should not center rows when scrolling them into view
+ https://bugs.webkit.org/show_bug.cgi?id=188593
+ <rdar://problem/43311660>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/Table.js:
+ (WI.Table.prototype._handleKeyDown):
+
2018-08-13 Matt Baker <[email protected]>
Web Inspector: Table should handle row selection instead of the table delegate
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Table.js (234881 => 234882)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2018-08-15 04:47:16 UTC (rev 234881)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Table.js 2018-08-15 06:10:34 UTC (rev 234882)
@@ -1173,7 +1173,7 @@
let row = this._cachedRows.get(this._selectedRowIndex);
console.assert(row, "Moving up or down by one should always find a cached row since it is within the overflow bounds.");
- row.scrollIntoViewIfNeeded();
+ row.scrollIntoViewIfNeeded(false);
// Force our own scroll update because we may have scrolled.
this._cachedScrollTop = NaN;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
