Title: [234890] trunk/Source/WebCore
- Revision
- 234890
- Author
- [email protected]
- Date
- 2018-08-15 10:48:07 -0700 (Wed, 15 Aug 2018)
Log Message
Remove failing assertion introduced in r234873
https://bugs.webkit.org/show_bug.cgi?id=188581
* contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
The assertion is correct but failing because VectorTraits<String> is incorrect.
I'll re-add it and fix VectorTraits<String> in a separate patch.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (234889 => 234890)
--- trunk/Source/WebCore/ChangeLog 2018-08-15 17:29:14 UTC (rev 234889)
+++ trunk/Source/WebCore/ChangeLog 2018-08-15 17:48:07 UTC (rev 234890)
@@ -1,3 +1,13 @@
+2018-08-15 Alex Christensen <[email protected]>
+
+ Remove failing assertion introduced in r234873
+ https://bugs.webkit.org/show_bug.cgi?id=188581
+
+ * contentextensions/ContentExtensionCompiler.cpp:
+ (WebCore::ContentExtensions::compileRuleList):
+ The assertion is correct but failing because VectorTraits<String> is incorrect.
+ I'll re-add it and fix VectorTraits<String> in a separate patch.
+
2018-08-15 Wenson Hsieh <[email protected]>
[Attachment SPI] Remove attachment display mode options
Modified: trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp (234889 => 234890)
--- trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp 2018-08-15 17:29:14 UTC (rev 234889)
+++ trunk/Source/WebCore/contentextensions/ContentExtensionCompiler.cpp 2018-08-15 17:48:07 UTC (rev 234890)
@@ -285,12 +285,6 @@
std::error_code compileRuleList(ContentExtensionCompilationClient& client, String&& ruleJSON, Vector<ContentExtensionRule>&& parsedRuleList)
{
-#if !ASSERT_DISABLED
- callOnMainThread([ruleJSON = ruleJSON.isolatedCopy(), parsedRuleList = parsedRuleList.isolatedCopy()] {
- ASSERT(parseRuleList(ruleJSON) == parsedRuleList);
- });
-#endif
-
bool domainConditionSeen = false;
bool topURLConditionSeen = false;
for (const auto& rule : parsedRuleList) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
