Title: [234894] trunk/Source/_javascript_Core
- Revision
- 234894
- Author
- [email protected]
- Date
- 2018-08-15 12:33:54 -0700 (Wed, 15 Aug 2018)
Log Message
Remove evernote hacks
https://bugs.webkit.org/show_bug.cgi?id=188591
Reviewed by Joseph Pecoraro.
The hack was added in 2012 and the evernote app seems to work now.
It's probably not needed anymore.
* API/JSValueRef.cpp:
(JSValueUnprotect):
(evernoteHackNeeded): Deleted.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/JSValueRef.cpp (234893 => 234894)
--- trunk/Source/_javascript_Core/API/JSValueRef.cpp 2018-08-15 18:59:19 UTC (rev 234893)
+++ trunk/Source/_javascript_Core/API/JSValueRef.cpp 2018-08-15 19:33:54 UTC (rev 234894)
@@ -54,17 +54,6 @@
using namespace JSC;
-#if PLATFORM(MAC)
-static bool evernoteHackNeeded()
-{
- static const int32_t webkitLastVersionWithEvernoteHack = 35133959;
- static bool hackNeeded = CFEqual(CFBundleGetIdentifier(CFBundleGetMainBundle()), CFSTR("com.evernote.Evernote"))
- && NSVersionOfLinkTimeLibrary("_javascript_Core") <= webkitLastVersionWithEvernoteHack;
-
- return hackNeeded;
-}
-#endif
-
::JSType JSValueGetType(JSContextRef ctx, JSValueRef value)
{
if (!ctx) {
@@ -485,11 +474,6 @@
void JSValueUnprotect(JSContextRef ctx, JSValueRef value)
{
-#if PLATFORM(MAC)
- if ((!value || !ctx) && evernoteHackNeeded())
- return;
-#endif
-
ExecState* exec = toJS(ctx);
JSLockHolder locker(exec);
Modified: trunk/Source/_javascript_Core/ChangeLog (234893 => 234894)
--- trunk/Source/_javascript_Core/ChangeLog 2018-08-15 18:59:19 UTC (rev 234893)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-08-15 19:33:54 UTC (rev 234894)
@@ -1,3 +1,17 @@
+2018-08-15 Keith Miller <[email protected]>
+
+ Remove evernote hacks
+ https://bugs.webkit.org/show_bug.cgi?id=188591
+
+ Reviewed by Joseph Pecoraro.
+
+ The hack was added in 2012 and the evernote app seems to work now.
+ It's probably not needed anymore.
+
+ * API/JSValueRef.cpp:
+ (JSValueUnprotect):
+ (evernoteHackNeeded): Deleted.
+
2018-08-14 Fujii Hironori <[email protected]>
Unreviewed, rolling out r234874 and r234876.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
