Title: [234929] trunk/Source/WebKit
- Revision
- 234929
- Author
- pvol...@apple.com
- Date
- 2018-08-16 08:53:31 -0700 (Thu, 16 Aug 2018)
Log Message
Assert that calling CGSSetDenyWindowServerConnections(true) succeeds
https://bugs.webkit.org/show_bug.cgi?id=188615
Reviewed by Brent Fulgham.
If the call to CGSSetDenyWindowServerConnections(true) fails, it means there are open WindowServer connections
at this point, and future WindowServer connections will not be denied. We should assert that this call succeeds.
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (234928 => 234929)
--- trunk/Source/WebKit/ChangeLog 2018-08-16 15:50:16 UTC (rev 234928)
+++ trunk/Source/WebKit/ChangeLog 2018-08-16 15:53:31 UTC (rev 234929)
@@ -1,3 +1,16 @@
+2018-08-16 Per Arne Vollan <pvol...@apple.com>
+
+ Assert that calling CGSSetDenyWindowServerConnections(true) succeeds
+ https://bugs.webkit.org/show_bug.cgi?id=188615
+
+ Reviewed by Brent Fulgham.
+
+ If the call to CGSSetDenyWindowServerConnections(true) fails, it means there are open WindowServer connections
+ at this point, and future WindowServer connections will not be denied. We should assert that this call succeeds.
+
+ * WebProcess/cocoa/WebProcessCocoa.mm:
+ (WebKit::WebProcess::platformInitializeProcess):
+
2018-08-16 Philippe Normand <pnorm...@igalia.com>
Unreviewed, WPE build fix after r234920.
Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (234928 => 234929)
--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2018-08-16 15:50:16 UTC (rev 234928)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm 2018-08-16 15:53:31 UTC (rev 234929)
@@ -323,7 +323,8 @@
#if ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)
// Deny the WebContent process access to the WindowServer.
// This call will not succeed if there are open WindowServer connections at this point.
- CGSSetDenyWindowServerConnections(true);
+ auto retval = CGSSetDenyWindowServerConnections(true);
+ RELEASE_ASSERT(retval == kCGErrorSuccess);
// Make sure that we close any WindowServer connections after checking in with Launch Services.
CGSShutdownServerConnections();
#else
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
