Title: [234960] trunk/Source/WebKit
- Revision
- 234960
- Author
- [email protected]
- Date
- 2018-08-16 15:10:20 -0700 (Thu, 16 Aug 2018)
Log Message
Add temporary SPI WKContextHandlesSafeBrowsing
https://bugs.webkit.org/show_bug.cgi?id=188676
Reviewed by Joseph Pecoraro.
WebKit showing the safe browsing warning doesn't play well with Safari showing the safe browsing warning.
I plan to adopt this SPI in Safari to disable Safari's safe browsing check if it's true.
Then when I implement safe browsing in WebKit, I can switch this value to true in the same change and
not have a broken Safari.
* UIProcess/API/C/mac/WKContextPrivateMac.h:
* UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextHandlesSafeBrowsing):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (234959 => 234960)
--- trunk/Source/WebKit/ChangeLog 2018-08-16 22:08:01 UTC (rev 234959)
+++ trunk/Source/WebKit/ChangeLog 2018-08-16 22:10:20 UTC (rev 234960)
@@ -1,3 +1,19 @@
+2018-08-16 Alex Christensen <[email protected]>
+
+ Add temporary SPI WKContextHandlesSafeBrowsing
+ https://bugs.webkit.org/show_bug.cgi?id=188676
+
+ Reviewed by Joseph Pecoraro.
+
+ WebKit showing the safe browsing warning doesn't play well with Safari showing the safe browsing warning.
+ I plan to adopt this SPI in Safari to disable Safari's safe browsing check if it's true.
+ Then when I implement safe browsing in WebKit, I can switch this value to true in the same change and
+ not have a broken Safari.
+
+ * UIProcess/API/C/mac/WKContextPrivateMac.h:
+ * UIProcess/API/C/mac/WKContextPrivateMac.mm:
+ (WKContextHandlesSafeBrowsing):
+
2018-08-16 Ben Richards <[email protected]>
Add script to generate WebContent service resource files
Modified: trunk/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.h (234959 => 234960)
--- trunk/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.h 2018-08-16 22:08:01 UTC (rev 234959)
+++ trunk/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.h 2018-08-16 22:10:20 UTC (rev 234960)
@@ -74,6 +74,8 @@
WK_EXPORT bool WKContextShouldBlockWebGL();
WK_EXPORT bool WKContextShouldSuggestBlockWebGL();
+WK_EXPORT bool WKContextHandlesSafeBrowsing();
+
#ifdef __cplusplus
}
#endif
Modified: trunk/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm (234959 => 234960)
--- trunk/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm 2018-08-16 22:08:01 UTC (rev 234959)
+++ trunk/Source/WebKit/UIProcess/API/C/mac/WKContextPrivateMac.mm 2018-08-16 22:10:20 UTC (rev 234960)
@@ -172,3 +172,8 @@
return false;
#endif
}
+
+bool WKContextHandlesSafeBrowsing()
+{
+ return false;
+}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
