Title: [235016] trunk/Source/WebKit
- Revision
- 235016
- Author
- [email protected]
- Date
- 2018-08-19 08:16:50 -0700 (Sun, 19 Aug 2018)
Log Message
REGRESSION (r234396): Leak of CFURLRef in WebKit::NetworkProcess::deleteHSTSCacheForHostNames()
<https://webkit.org/b/188725>
Reviewed by Dan Bernstein.
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::deleteHSTSCacheForHostNames): Use
adoptCF() to prevent a leak.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (235015 => 235016)
--- trunk/Source/WebKit/ChangeLog 2018-08-19 03:28:59 UTC (rev 235015)
+++ trunk/Source/WebKit/ChangeLog 2018-08-19 15:16:50 UTC (rev 235016)
@@ -1,3 +1,14 @@
+2018-08-19 David Kilzer <[email protected]>
+
+ REGRESSION (r234396): Leak of CFURLRef in WebKit::NetworkProcess::deleteHSTSCacheForHostNames()
+ <https://webkit.org/b/188725>
+
+ Reviewed by Dan Bernstein.
+
+ * NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+ (WebKit::NetworkProcess::deleteHSTSCacheForHostNames): Use
+ adoptCF() to prevent a leak.
+
2018-08-18 Andy Estes <[email protected]>
[watchOS] NetworkProximityManager should use WTF_MAKE_FAST_ALLOCATED
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm (235015 => 235016)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2018-08-19 03:28:59 UTC (rev 235015)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkProcessCocoa.mm 2018-08-19 15:16:50 UTC (rev 235016)
@@ -45,6 +45,7 @@
#import <wtf/BlockPtr.h>
#import <wtf/CallbackAggregator.h>
#import <wtf/ProcessPrivilege.h>
+#import <wtf/RetainPtr.h>
namespace WebKit {
@@ -159,8 +160,10 @@
void NetworkProcess::deleteHSTSCacheForHostNames(WebCore::NetworkStorageSession& session, const Vector<String>& hostNames)
{
- for (auto& hostName : hostNames)
- _CFNetworkResetHSTS(CFURLCreateWithString(kCFAllocatorDefault, hostName.createCFString().get(), NULL), session.platformSession());
+ for (auto& hostName : hostNames) {
+ auto url = "" hostName.createCFString().get(), NULL));
+ _CFNetworkResetHSTS(url.get(), session.platformSession());
+ }
}
void NetworkProcess::clearHSTSCache(WebCore::NetworkStorageSession& session, WallTime modifiedSince)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
