Title: [235087] trunk/Source/WebCore
- Revision
- 235087
- Author
- [email protected]
- Date
- 2018-08-20 11:38:05 -0700 (Mon, 20 Aug 2018)
Log Message
UIWebView crashes while attempting to play youtube video on phone
https://bugs.webkit.org/show_bug.cgi?id=188351
rdar://problem/42489664
Patch by Jeremy Jones <[email protected]> on 2018-08-20
Reviewed by David Kilzer.
Test will be incorporated with fix for 188749, which will test both fixes.
VideoFullscreenControllerContext must remove unretained reference to it from m_playbackModel during cleanup.
* platform/ios/WebVideoFullscreenControllerAVKit.mm:
(VideoFullscreenControllerContext::didCleanupFullscreen):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (235086 => 235087)
--- trunk/Source/WebCore/ChangeLog 2018-08-20 18:10:22 UTC (rev 235086)
+++ trunk/Source/WebCore/ChangeLog 2018-08-20 18:38:05 UTC (rev 235087)
@@ -1,3 +1,18 @@
+2018-08-20 Jeremy Jones <[email protected]>
+
+ UIWebView crashes while attempting to play youtube video on phone
+ https://bugs.webkit.org/show_bug.cgi?id=188351
+ rdar://problem/42489664
+
+ Reviewed by David Kilzer.
+
+ Test will be incorporated with fix for 188749, which will test both fixes.
+
+ VideoFullscreenControllerContext must remove unretained reference to it from m_playbackModel during cleanup.
+
+ * platform/ios/WebVideoFullscreenControllerAVKit.mm:
+ (VideoFullscreenControllerContext::didCleanupFullscreen):
+
2018-08-20 Eric Carlson <[email protected]>
[MediaStream] Move capture device monitoring to WebKit
Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm (235086 => 235087)
--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm 2018-08-20 18:10:22 UTC (rev 235086)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenControllerAVKit.mm 2018-08-20 18:38:05 UTC (rev 235087)
@@ -328,6 +328,7 @@
m_fullscreenModel->setVideoFullscreenLayer(nil);
m_fullscreenModel->setVideoElement(nullptr);
m_playbackModel->setMediaElement(nullptr);
+ m_playbackModel->removeClient(*this);
m_fullscreenModel->removeClient(*this);
m_fullscreenModel = nullptr;
m_videoElement = nullptr;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
