Title: [235126] trunk/LayoutTests
- Revision
- 235126
- Author
- [email protected]
- Date
- 2018-08-21 11:08:25 -0700 (Tue, 21 Aug 2018)
Log Message
REGRESSION(r234993): Test results page ignores TestExpectations, shows 1800 failures
https://bugs.webkit.org/show_bug.cgi?id=188795
Reviewed by Tim Horton.
A MISSING result would trigger a code path that hit appendActualOnlyLinks() which had
a JS error, causing all expected results to be visible. Fix with a change to full_results.json
which tests the change.
* fast/harness/full_results.json:
* fast/harness/results.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (235125 => 235126)
--- trunk/LayoutTests/ChangeLog 2018-08-21 18:04:48 UTC (rev 235125)
+++ trunk/LayoutTests/ChangeLog 2018-08-21 18:08:25 UTC (rev 235126)
@@ -1,3 +1,17 @@
+2018-08-21 Simon Fraser <[email protected]>
+
+ REGRESSION(r234993): Test results page ignores TestExpectations, shows 1800 failures
+ https://bugs.webkit.org/show_bug.cgi?id=188795
+
+ Reviewed by Tim Horton.
+
+ A MISSING result would trigger a code path that hit appendActualOnlyLinks() which had
+ a JS error, causing all expected results to be visible. Fix with a change to full_results.json
+ which tests the change.
+
+ * fast/harness/full_results.json:
+ * fast/harness/results.html:
+
2018-08-21 Per Arne Vollan <[email protected]>
[WebGL] Contexts are not updated when display configuration changed.
Modified: trunk/LayoutTests/fast/harness/full_results.json (235125 => 235126)
--- trunk/LayoutTests/fast/harness/full_results.json 2018-08-21 18:04:48 UTC (rev 235125)
+++ trunk/LayoutTests/fast/harness/full_results.json 2018-08-21 18:08:25 UTC (rev 235126)
@@ -42,6 +42,11 @@
"expected": "PASS TIMEOUT",
"actual": "TEXT PASS TIMEOUT"
},
+ "scale-transition-no-start.html": {
+ "expected": "FAIL MISSING",
+ "is_missing_text": true,
+ "actual": "MISSING"
+ }
},
"canvas": {
"philip": {
Modified: trunk/LayoutTests/fast/harness/results.html (235125 => 235126)
--- trunk/LayoutTests/fast/harness/results.html 2018-08-21 18:04:48 UTC (rev 235125)
+++ trunk/LayoutTests/fast/harness/results.html 2018-08-21 18:08:25 UTC (rev 235126)
@@ -1234,6 +1234,7 @@
appendActualOnlyLinks(testResult, cell)
{
+ let prefix = Utils.stripExtension(testResult.name);
if (testResult.info.is_missing_audio)
cell.innerHTML += TestResultsController.resultLink(prefix, '-actual.wav', 'audio result');
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
