Title: [235148] trunk
- Revision
- 235148
- Author
- achristen...@apple.com
- Date
- 2018-08-21 16:59:03 -0700 (Tue, 21 Aug 2018)
Log Message
Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient
https://bugs.webkit.org/show_bug.cgi?id=188821
Reviewed by Simon Fraser.
Source/WebKit:
Add some more values to WKPageRenderingProgressEvents which were already supported by _WKRenderingProgressEvents and WKLayoutMilestones.
* UIProcess/API/C/WKPageRenderingProgressEvents.h:
* UIProcess/API/C/WKPageRenderingProgressEventsInternal.h:
(pageRenderingProgressEvents):
Tools:
* TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
(TestWebKitAPI::didLayout):
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (235147 => 235148)
--- trunk/Source/WebKit/ChangeLog 2018-08-21 23:58:21 UTC (rev 235147)
+++ trunk/Source/WebKit/ChangeLog 2018-08-21 23:59:03 UTC (rev 235148)
@@ -1,5 +1,18 @@
2018-08-21 Alex Christensen <achristen...@webkit.org>
+ Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient
+ https://bugs.webkit.org/show_bug.cgi?id=188821
+
+ Reviewed by Simon Fraser.
+
+ Add some more values to WKPageRenderingProgressEvents which were already supported by _WKRenderingProgressEvents and WKLayoutMilestones.
+
+ * UIProcess/API/C/WKPageRenderingProgressEvents.h:
+ * UIProcess/API/C/WKPageRenderingProgressEventsInternal.h:
+ (pageRenderingProgressEvents):
+
+2018-08-21 Alex Christensen <achristen...@webkit.org>
+
Fix API tests after r235139
https://bugs.webkit.org/show_bug.cgi?id=188805
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h (235147 => 235148)
--- trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h 2018-08-21 23:58:21 UTC (rev 235147)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEvents.h 2018-08-21 23:59:03 UTC (rev 235148)
@@ -36,7 +36,9 @@
WKPageRenderingProgressEventFirstLayout = 1 << 0,
WKPageRenderingProgressEventFirstVisuallyNonEmptyLayout = 1 << 1,
WKPageRenderingProgressEventFirstPaintWithSignificantArea = 1 << 2,
- WKPageRenderingProgressEventReachedSessionRestorationRenderTreeSizeThreshold = 1 << 3
+ WKPageRenderingProgressEventReachedSessionRestorationRenderTreeSizeThreshold = 1 << 3,
+ WKPageRenderingProgressEventFirstLayoutAfterSuppressedIncrementalRendering = 1 << 4,
+ WKPageRenderingProgressEventFirstPaintAfterSuppressedIncrementalRendering = 1 << 5,
};
typedef uint32_t WKPageRenderingProgressEvents;
Modified: trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEventsInternal.h (235147 => 235148)
--- trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEventsInternal.h 2018-08-21 23:58:21 UTC (rev 235147)
+++ trunk/Source/WebKit/UIProcess/API/C/WKPageRenderingProgressEventsInternal.h 2018-08-21 23:59:03 UTC (rev 235148)
@@ -43,5 +43,11 @@
if (milestones & WebCore::ReachedSessionRestorationRenderTreeSizeThreshold)
events |= WKPageRenderingProgressEventReachedSessionRestorationRenderTreeSizeThreshold;
+ if (milestones & WebCore::DidFirstLayoutAfterSuppressedIncrementalRendering)
+ events |= WKPageRenderingProgressEventFirstLayoutAfterSuppressedIncrementalRendering;
+
+ if (milestones & WebCore::DidFirstPaintAfterSuppressedIncrementalRendering)
+ events |= WKPageRenderingProgressEventFirstPaintAfterSuppressedIncrementalRendering;
+
return events;
}
Modified: trunk/Tools/ChangeLog (235147 => 235148)
--- trunk/Tools/ChangeLog 2018-08-21 23:58:21 UTC (rev 235147)
+++ trunk/Tools/ChangeLog 2018-08-21 23:59:03 UTC (rev 235148)
@@ -1,3 +1,14 @@
+2018-08-21 Alex Christensen <achristen...@webkit.org>
+
+ Transition ResizeReversePaginatedWebView API test from WKPageLoaderClient to WKPageNavigationClient
+ https://bugs.webkit.org/show_bug.cgi?id=188821
+
+ Reviewed by Simon Fraser.
+
+ * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
+ (TestWebKitAPI::didLayout):
+ (TestWebKitAPI::TEST):
+
2018-08-21 Myles C. Maxfield <mmaxfi...@apple.com>
[WHLSL] Call expressions shouldn't have type arguments
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp (235147 => 235148)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp 2018-08-21 23:58:21 UTC (rev 235147)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp 2018-08-21 23:59:03 UTC (rev 235148)
@@ -44,7 +44,7 @@
static const unsigned pageGap = 100;
static const unsigned expectedPageCount = 20;
-static void didLayout(WKPageRef page, WKLayoutMilestones milestones, WKTypeRef, const void* clientInfo)
+static void didLayout(WKPageRef page, WKPageRenderingProgressEvents milestones, WKTypeRef, const void* clientInfo)
{
if (milestones & kWKDidFirstLayoutAfterSuppressedIncrementalRendering) {
PlatformWebView* webView = (PlatformWebView*)clientInfo;
@@ -64,14 +64,14 @@
WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate());
PlatformWebView webView(context.get());
- WKPageLoaderClientV3 loaderClient;
+ WKPageNavigationClientV3 loaderClient;
memset(&loaderClient, 0, sizeof(loaderClient));
loaderClient.base.version = 3;
loaderClient.base.clientInfo = &webView;
- loaderClient.didLayout = didLayout;
+ loaderClient.renderingProgressDidChange = didLayout;
- WKPageSetPageLoaderClient(webView.page(), &loaderClient.base);
+ WKPageSetPageNavigationClient(webView.page(), &loaderClient.base);
WKPageListenForLayoutMilestones(webView.page(), kWKDidFirstLayoutAfterSuppressedIncrementalRendering);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
