Title: [235247] trunk/Source/WebKit
- Revision
- 235247
- Author
- [email protected]
- Date
- 2018-08-23 14:31:22 -0700 (Thu, 23 Aug 2018)
Log Message
Unreviewed, rolling out r234942.
Caused page loading issues in iTunes
Reverted changeset:
"Transition more WKWebViewConfiguration ivars to
API::PageConfiguration values"
https://bugs.webkit.org/show_bug.cgi?id=188663
https://trac.webkit.org/changeset/234942
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (235246 => 235247)
--- trunk/Source/WebKit/ChangeLog 2018-08-23 21:26:35 UTC (rev 235246)
+++ trunk/Source/WebKit/ChangeLog 2018-08-23 21:31:22 UTC (rev 235247)
@@ -1,3 +1,16 @@
+2018-08-23 Ryan Haddad <[email protected]>
+
+ Unreviewed, rolling out r234942.
+
+ Caused page loading issues in iTunes
+
+ Reverted changeset:
+
+ "Transition more WKWebViewConfiguration ivars to
+ API::PageConfiguration values"
+ https://bugs.webkit.org/show_bug.cgi?id=188663
+ https://trac.webkit.org/changeset/234942
+
2018-08-23 Aditya Keerthi <[email protected]>
[iOS] Support the inputmode attribute on contenteditable elements
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (235246 => 235247)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-08-23 21:26:35 UTC (rev 235246)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-08-23 21:31:22 UTC (rev 235247)
@@ -546,6 +546,9 @@
pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::shouldConvertPositionStyleOnCopyKey(), WebKit::WebPreferencesStore::Value(!![_configuration _convertsPositionStyleOnCopy]));
pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::httpEquivEnabledKey(), WebKit::WebPreferencesStore::Value(!![_configuration _allowsMetaRefresh]));
pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::allowUniversalAccessFromFileURLsKey(), WebKit::WebPreferencesStore::Value(!![_configuration _allowUniversalAccessFromFileURLs]));
+ pageConfiguration->setWaitsForPaintAfterViewDidMoveToWindow([_configuration _waitsForPaintAfterViewDidMoveToWindow]);
+ pageConfiguration->setDrawsBackground([_configuration _drawsBackground]);
+ pageConfiguration->setControlledByAutomation([_configuration _isControlledByAutomation]);
pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::incompleteImageBorderEnabledKey(), WebKit::WebPreferencesStore::Value(!![_configuration _incompleteImageBorderEnabled]));
pageConfiguration->preferenceValues().set(WebKit::WebPreferencesKey::shouldDeferAsynchronousScriptsUntilAfterDocumentLoadKey(), WebKit::WebPreferencesStore::Value(!![_configuration _shouldDeferAsynchronousScriptsUntilAfterDocumentLoad]));
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (235246 => 235247)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2018-08-23 21:26:35 UTC (rev 235246)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2018-08-23 21:31:22 UTC (rev 235247)
@@ -147,6 +147,8 @@
BOOL _imageControlsEnabled;
BOOL _requiresUserActionForEditingControlsManager;
#endif
+ BOOL _waitsForPaintAfterViewDidMoveToWindow;
+ BOOL _controlledByAutomation;
#if ENABLE(APPLE_PAY)
BOOL _applePayEnabled;
@@ -157,6 +159,7 @@
BOOL _colorFilterEnabled;
BOOL _incompleteImageBorderEnabled;
BOOL _shouldDeferAsynchronousScriptsUntilAfterDocumentLoad;
+ BOOL _drawsBackground;
RetainPtr<NSString> _mediaContentTypesRequiringHardwareSupport;
}
@@ -209,6 +212,7 @@
_imageControlsEnabled = NO;
_requiresUserActionForEditingControlsManager = NO;
#endif
+ _waitsForPaintAfterViewDidMoveToWindow = YES;
#if ENABLE(WIRELESS_PLAYBACK_TARGET)
_allowsAirPlayForMediaPlayback = YES;
@@ -240,6 +244,7 @@
_colorFilterEnabled = NO;
_incompleteImageBorderEnabled = NO;
_shouldDeferAsynchronousScriptsUntilAfterDocumentLoad = NO;
+ _drawsBackground = YES;
return self;
}
@@ -354,6 +359,8 @@
configuration->_attachmentElementEnabled = self->_attachmentElementEnabled;
configuration->_mediaTypesRequiringUserActionForPlayback = self->_mediaTypesRequiringUserActionForPlayback;
configuration->_mainContentUserGestureOverrideEnabled = self->_mainContentUserGestureOverrideEnabled;
+ configuration->_waitsForPaintAfterViewDidMoveToWindow = self->_waitsForPaintAfterViewDidMoveToWindow;
+ configuration->_controlledByAutomation = self->_controlledByAutomation;
#if PLATFORM(IOS)
configuration->_allowsInlineMediaPlayback = self->_allowsInlineMediaPlayback;
@@ -394,6 +401,7 @@
configuration->_colorFilterEnabled = self->_colorFilterEnabled;
configuration->_incompleteImageBorderEnabled = self->_incompleteImageBorderEnabled;
configuration->_shouldDeferAsynchronousScriptsUntilAfterDocumentLoad = self->_shouldDeferAsynchronousScriptsUntilAfterDocumentLoad;
+ configuration->_drawsBackground = self->_drawsBackground;
return configuration;
}
@@ -773,12 +781,12 @@
- (BOOL)_drawsBackground
{
- return _pageConfiguration->drawsBackground();
+ return _drawsBackground;
}
- (void)_setDrawsBackground:(BOOL)drawsBackground
{
- _pageConfiguration->setDrawsBackground(drawsBackground);
+ _drawsBackground = drawsBackground;
}
- (BOOL)_requiresUserActionForVideoPlayback
@@ -829,22 +837,22 @@
- (BOOL)_waitsForPaintAfterViewDidMoveToWindow
{
- return _pageConfiguration->waitsForPaintAfterViewDidMoveToWindow();
+ return _waitsForPaintAfterViewDidMoveToWindow;
}
-- (void)_setWaitsForPaintAfterViewDidMoveToWindow:(BOOL)waitsForPaintAfterViewDidMoveToWindow
+- (void)_setWaitsForPaintAfterViewDidMoveToWindow:(BOOL)shouldSynchronize
{
- _pageConfiguration->setWaitsForPaintAfterViewDidMoveToWindow(waitsForPaintAfterViewDidMoveToWindow);
+ _waitsForPaintAfterViewDidMoveToWindow = shouldSynchronize;
}
- (BOOL)_isControlledByAutomation
{
- return _pageConfiguration->isControlledByAutomation();
+ return _controlledByAutomation;
}
- (void)_setControlledByAutomation:(BOOL)controlledByAutomation
{
- _pageConfiguration->setControlledByAutomation(controlledByAutomation);
+ _controlledByAutomation = controlledByAutomation;
}
- (_WKApplicationManifest *)_applicationManifest
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
