Title: [235316] trunk/Source/WebCore
- Revision
- 235316
- Author
- [email protected]
- Date
- 2018-08-24 03:12:56 -0700 (Fri, 24 Aug 2018)
Log Message
Remove ScrollByPrecisePixel granularity
https://bugs.webkit.org/show_bug.cgi?id=188915
Patch by Frederic Wang <[email protected]> on 2018-08-24
Reviewed by Carlos Garcia Campos.
ScrollByPrecisePixel was introduced in bug 87535 and bug 91020 for Chromium Linux/Windows but
it is no longer used.
No new tests, behavior unchanged.
* platform/ScrollAnimatorSmooth.cpp:
(WebCore::ScrollAnimatorSmooth::scroll): Remove special handling for ScrollByPrecisePixel.
* platform/ScrollTypes.h: Remove ScrollByPrecisePixel, it is never used.
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scroll): Remove special handling for ScrollByPrecisePixel.
* platform/gtk/ScrollAnimatorGtk.cpp:
(WebCore::ScrollAnimatorGtk::scroll): Remove special handling for ScrollByPrecisePixel.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (235315 => 235316)
--- trunk/Source/WebCore/ChangeLog 2018-08-24 09:30:52 UTC (rev 235315)
+++ trunk/Source/WebCore/ChangeLog 2018-08-24 10:12:56 UTC (rev 235316)
@@ -1,3 +1,23 @@
+2018-08-24 Frederic Wang <[email protected]>
+
+ Remove ScrollByPrecisePixel granularity
+ https://bugs.webkit.org/show_bug.cgi?id=188915
+
+ Reviewed by Carlos Garcia Campos.
+
+ ScrollByPrecisePixel was introduced in bug 87535 and bug 91020 for Chromium Linux/Windows but
+ it is no longer used.
+
+ No new tests, behavior unchanged.
+
+ * platform/ScrollAnimatorSmooth.cpp:
+ (WebCore::ScrollAnimatorSmooth::scroll): Remove special handling for ScrollByPrecisePixel.
+ * platform/ScrollTypes.h: Remove ScrollByPrecisePixel, it is never used.
+ * platform/ScrollableArea.cpp:
+ (WebCore::ScrollableArea::scroll): Remove special handling for ScrollByPrecisePixel.
+ * platform/gtk/ScrollAnimatorGtk.cpp:
+ (WebCore::ScrollAnimatorGtk::scroll): Remove special handling for ScrollByPrecisePixel.
+
2018-08-24 Antti Koivisto <[email protected]>
Allow creating WeakPtrs to const objects
Modified: trunk/Source/WebCore/platform/ScrollAnimatorSmooth.cpp (235315 => 235316)
--- trunk/Source/WebCore/platform/ScrollAnimatorSmooth.cpp 2018-08-24 09:30:52 UTC (rev 235315)
+++ trunk/Source/WebCore/platform/ScrollAnimatorSmooth.cpp 2018-08-24 10:12:56 UTC (rev 235316)
@@ -60,7 +60,7 @@
bool ScrollAnimatorSmooth::scroll(ScrollbarOrientation orientation, ScrollGranularity granularity, float step, float multiplier)
{
- if (!m_scrollableArea.scrollAnimatorEnabled() || granularity == ScrollByPrecisePixel)
+ if (!m_scrollableArea.scrollAnimatorEnabled())
return ScrollAnimator::scroll(orientation, granularity, step, multiplier);
return m_animation->scroll(orientation, granularity, step, multiplier);
Modified: trunk/Source/WebCore/platform/ScrollTypes.h (235315 => 235316)
--- trunk/Source/WebCore/platform/ScrollTypes.h 2018-08-24 09:30:52 UTC (rev 235315)
+++ trunk/Source/WebCore/platform/ScrollTypes.h 2018-08-24 10:12:56 UTC (rev 235316)
@@ -108,8 +108,7 @@
ScrollByLine,
ScrollByPage,
ScrollByDocument,
- ScrollByPixel,
- ScrollByPrecisePixel
+ ScrollByPixel
};
enum ScrollElasticity {
Modified: trunk/Source/WebCore/platform/ScrollableArea.cpp (235315 => 235316)
--- trunk/Source/WebCore/platform/ScrollableArea.cpp 2018-08-24 09:30:52 UTC (rev 235315)
+++ trunk/Source/WebCore/platform/ScrollableArea.cpp 2018-08-24 10:12:56 UTC (rev 235316)
@@ -127,7 +127,6 @@
step = scrollbar->totalSize();
break;
case ScrollByPixel:
- case ScrollByPrecisePixel:
step = scrollbar->pixelStep();
break;
}
Modified: trunk/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp (235315 => 235316)
--- trunk/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp 2018-08-24 09:30:52 UTC (rev 235315)
+++ trunk/Source/WebCore/platform/gtk/ScrollAnimatorGtk.cpp 2018-08-24 10:12:56 UTC (rev 235316)
@@ -82,7 +82,7 @@
#if ENABLE(SMOOTH_SCROLLING)
bool ScrollAnimatorGtk::scroll(ScrollbarOrientation orientation, ScrollGranularity granularity, float step, float multiplier)
{
- if (!m_scrollableArea.scrollAnimatorEnabled() || granularity == ScrollByPrecisePixel)
+ if (!m_scrollableArea.scrollAnimatorEnabled())
return ScrollAnimator::scroll(orientation, granularity, step, multiplier);
ensureSmoothScrollingAnimation();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
