Title: [235321] trunk/Source/WebKit
- Revision
- 235321
- Author
- [email protected]
- Date
- 2018-08-24 10:46:01 -0700 (Fri, 24 Aug 2018)
Log Message
Don't launch network process in WebCookieManagerProxy::setHTTPCookieAcceptPolicy
https://bugs.webkit.org/show_bug.cgi?id=188906
<rdar://problem/43539661>
Reviewed by Geoffrey Garen.
In WebCookieManagerProxy::setHTTPCookieAcceptPolicy, we persist the cookieAcceptPolicy of
sharedCookieStorage. When we launch the network process later, we pass the
identifier of sharedCookieStorage to network process, so network process has the correct
cookieAcceptPolicy. Therefore, we don't have to launch the network process and send the
setting message if the network process is not launched.
* UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (235320 => 235321)
--- trunk/Source/WebKit/ChangeLog 2018-08-24 16:35:04 UTC (rev 235320)
+++ trunk/Source/WebKit/ChangeLog 2018-08-24 17:46:01 UTC (rev 235321)
@@ -1,3 +1,20 @@
+2018-08-24 Sihui Liu <[email protected]>
+
+ Don't launch network process in WebCookieManagerProxy::setHTTPCookieAcceptPolicy
+ https://bugs.webkit.org/show_bug.cgi?id=188906
+ <rdar://problem/43539661>
+
+ Reviewed by Geoffrey Garen.
+
+ In WebCookieManagerProxy::setHTTPCookieAcceptPolicy, we persist the cookieAcceptPolicy of
+ sharedCookieStorage. When we launch the network process later, we pass the
+ identifier of sharedCookieStorage to network process, so network process has the correct
+ cookieAcceptPolicy. Therefore, we don't have to launch the network process and send the
+ setting message if the network process is not launched.
+
+ * UIProcess/WebCookieManagerProxy.cpp:
+ (WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
+
2018-08-23 Carlos Garcia Campos <[email protected]>
[GTK][WPE] Add API to inject/register user content in isolated worlds
Modified: trunk/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp (235320 => 235321)
--- trunk/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp 2018-08-24 16:35:04 UTC (rev 235320)
+++ trunk/Source/WebKit/UIProcess/WebCookieManagerProxy.cpp 2018-08-24 17:46:01 UTC (rev 235321)
@@ -251,6 +251,9 @@
processPool()->setInitialHTTPCookieAcceptPolicy(policy);
#endif
+ if (!processPool()->networkProcess())
+ return;
+
auto callbackID = m_callbacks.put(WTFMove(callbackFunction), processPool()->ensureNetworkProcess().throttler().backgroundActivityToken());
processPool()->sendToNetworkingProcess(Messages::WebCookieManager::SetHTTPCookieAcceptPolicy(policy, OptionalCallbackID(callbackID)));
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
